linux-next: build failure after merge of the async_tx tree

linux-next: build failure after merge of the async_tx tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 5030 bytes --]

Hi Dan,

After merging the async_tx tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/dma/pl330.c:19:
include/linux/amba/pl330.h:15:32: error: asm/hardware/pl330.h: No such file or directory
In file included from drivers/dma/pl330.c:19:
include/linux/amba/pl330.h:23: error: field 'rqtype' has incomplete type
drivers/dma/pl330.c:74: error: field 'pif' has incomplete type
drivers/dma/pl330.c:96: error: field 'px' has incomplete type
drivers/dma/pl330.c:98: error: field 'rqcfg' has incomplete type
drivers/dma/pl330.c:99: error: field 'req' has incomplete type
drivers/dma/pl330.c: In function 'fill_queue':
drivers/dma/pl330.c:166: error: implicit declaration of function 'pl330_submit_req'
drivers/dma/pl330.c: In function 'pl330_tasklet':
drivers/dma/pl330.c:204: error: implicit declaration of function 'pl330_chan_ctrl'
drivers/dma/pl330.c:204: error: 'PL330_OP_START' undeclared (first use in this function)
drivers/dma/pl330.c:204: error: (Each undeclared identifier is reported only once
drivers/dma/pl330.c:204: error: for each function it appears in.)
drivers/dma/pl330.c: At top level:
drivers/dma/pl330.c:211: warning: 'enum pl330_op_err' declared inside parameter list
drivers/dma/pl330.c:211: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/dma/pl330.c:211: error: parameter 2 ('err') has incomplete type
drivers/dma/pl330.c: In function 'pl330_alloc_chan_resources':
drivers/dma/pl330.c:240: error: implicit declaration of function 'pl330_request_channel'
drivers/dma/pl330.c: In function 'pl330_control':
drivers/dma/pl330.c:266: error: 'PL330_OP_FLUSH' undeclared (first use in this function)
drivers/dma/pl330.c: In function 'pl330_free_chan_resources':
drivers/dma/pl330.c:288: error: implicit declaration of function 'pl330_release_channel'
drivers/dma/pl330.c: In function '_init_desc':
drivers/dma/pl330.c:362: error: 'SWAP_NO' undeclared (first use in this function)
drivers/dma/pl330.c:365: error: 'SCCTRL0' undeclared (first use in this function)
drivers/dma/pl330.c:366: error: 'DCCTRL0' undeclared (first use in this function)
drivers/dma/pl330.c: In function 'fill_px':
drivers/dma/pl330.c:465: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:466: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:467: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:468: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c: In function 'get_burst_len':
drivers/dma/pl330.c:505: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:506: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c: In function 'pl330_prep_dma_memcpy':
drivers/dma/pl330.c:535: error: 'MEMTOMEM' undeclared (first use in this function)
drivers/dma/pl330.c:548: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c: In function 'pl330_prep_slave_sg':
drivers/dma/pl330.c:585: error: 'MEMTODEV' undeclared (first use in this function)
drivers/dma/pl330.c:587: error: 'DEVTOMEM' undeclared (first use in this function)
drivers/dma/pl330.c: In function 'pl330_irq_handler':
drivers/dma/pl330.c:653: error: implicit declaration of function 'pl330_update'
drivers/dma/pl330.c: In function 'pl330_probe':
drivers/dma/pl330.c:686: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:687: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:688: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:693: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:694: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:705: error: implicit declaration of function 'pl330_add'
drivers/dma/pl330.c:725: error: 'MEMTOMEM' undeclared (first use in this function)
drivers/dma/pl330.c:728: error: 'MEMTODEV' undeclared (first use in this function)
drivers/dma/pl330.c:729: error: 'DEVTOMEM' undeclared (first use in this function)
drivers/dma/pl330.c:770: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:770: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:770: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:770: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:770: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c:779: error: implicit declaration of function 'pl330_del'
drivers/dma/pl330.c:783: error: dereferencing pointer to incomplete type
drivers/dma/pl330.c: In function 'pl330_remove':
drivers/dma/pl330.c:823: error: dereferencing pointer to incomplete type

Caused by commit 0376653c268fce662831fbd109ce9811b25c16c2 ("DMA: PL330:
Add dma api driver").  Maybe this depends on a particular architecture?

I have used the async_tx tree from next-20100522 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the async_tx tree

[Jassi Brar]

On Mon, May 24, 2010 at 10:24 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

.....

> Caused by commit 0376653c268fce662831fbd109ce9811b25c16c2 ("DMA: PL330:
> Add dma api driver").  Maybe this depends on a particular architecture?

This driver is for any platform that has the ARM's Primcell DMAC
PL330. So there is no dependency on ARCH_xxxx
Any platform with such a DMAC should select PL330 and this driver
had better be build depending upon PL330 rather than selecting  PL330.

Something like...

config PL330_DMA
       tristate "DMA API Driver for PL330"
       select DMA_ENGINE
-       select PL330
+      depends on PL330
       help
         Select if your platform has one or more PL330 DMACs.
         You need to provide platform specific settings via
         platform_data for a dma-pl330 device.

I am not aware of how such issues are fixed at this stage, please
let me know what is expected of me.

Regards.

Re: linux-next: build failure after merge of the async_tx tree

[Dan Williams]

On Sun, May 23, 2010 at 6:24 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Dan,
>
> After merging the async_tx tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/dma/pl330.c:19:
> include/linux/amba/pl330.h:15:32: error: asm/hardware/pl330.h: No such file or directory

Should have caught that in the review... changed the 'select PL330' to
a 'depends on PL300' and pushed it back out.

Thanks,
Dan

Re: linux-next: build failure after merge of the async_tx tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi Dan,

On Sun, 23 May 2010 20:42:38 -0700 Dan Williams <dan.j.williams@intel.com> wrote:
>
> Should have caught that in the review... changed the 'select PL330' to
> a 'depends on PL300' and pushed it back out.

Thanks, I will pick it up tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the async_tx tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi Jassi,

On Mon, 24 May 2010 10:59:22 +0900 Jassi Brar <jassisinghbrar@gmail.com> wrote:
>
> I am not aware of how such issues are fixed at this stage, please
> let me know what is expected of me.

Dan has fixed it up in his tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]