From: Matthew Garrett <mjg@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Ben Skeggs <bskeggs@redhat.com>,
dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH -next] nouveau: fix acpi_lid_open undefined
Date: Mon, 24 May 2010 14:59:40 +0100 [thread overview]
Message-ID: <20100524135940.GA15892@srcf.ucam.org> (raw)
In-Reply-To: <4BFA84EF.7070609@oracle.com>
On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote:
> On 05/24/10 05:56, Matthew Garrett wrote:
> > Won't this result in a behavioural difference? The desirable outcome is
>
> It could, yes.
>
> > that that configuration be impossible, not for that configuration to
> > build but be buggy.
>
> so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON?
There's an argument that it doesn't need to depend on it, but if button
is a module then nouveau has to be. Except the inverse isn't true.
Kconfig is hard, let's weep gently.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-05-24 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 7:04 linux-next: Tree for May 22 Stephen Rothwell
2010-05-23 22:15 ` [PATCH -next] x86/platform: classmate-laptop depends on RFKILL Randy Dunlap
2010-05-23 23:33 ` [PATCH -next] platform/x86: msi-laptop depends on SERIO_I8042 Randy Dunlap
2010-05-28 17:24 ` Matthew Garrett
2010-05-24 0:00 ` [PATCH -next] nouveau: fix acpi_lid_open undefined Randy Dunlap
2010-05-24 0:09 ` Ben Skeggs
2010-05-24 12:56 ` Matthew Garrett
2010-05-24 13:53 ` Randy Dunlap
2010-05-24 13:59 ` Matthew Garrett [this message]
2010-05-24 14:17 ` Randy Dunlap
2010-05-24 22:47 ` Dave Airlie
2010-05-25 3:27 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100524135940.GA15892@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).