From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328Ab0EXXgT (ORCPT ); Mon, 24 May 2010 19:36:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177Ab0EXXgR (ORCPT ); Mon, 24 May 2010 19:36:17 -0400 Date: Mon, 24 May 2010 19:35:52 -0400 From: Mike Snitzer To: Will Drewry Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t Message-ID: <20100524233552.GA7204@redhat.com> References: <1274294304-30606-1-git-send-email-wad@chromium.org> <1274294304-30606-3-git-send-email-wad@chromium.org> <20100524115737.GY3991@agk-dp.fab.redhat.com> <20100524150729.GZ3991@agk-dp.fab.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24 2010 at 12:35pm -0400, Will Drewry wrote: > On Mon, May 24, 2010 at 10:07 AM, Alasdair G Kergon wrote: > > On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote: > >> fwiw, the only reason for the copy was because |path| is a > >> const in the function but not when passed to name_to_dev_t. > >> I wasn't sure what the preferred practice was so I just duped > >> the data needed. > > > > Well check that it is treated as 'const' and send a separate patch to > > the maintainer to add const, perhaps?  If it isn't const (why would > > that be?), then yes we'd need to copy it. > > I'll cross-check the code again and send a patch out if it looks like > it is const-safe. Also, it would see that name_to_dev_t is EXPORT_SYMBOL? Mike