From: Greg KH <gregkh@suse.de>
To: nanakos@wired-net.gr
Cc: martyn.welch@ge.com, wfp5p@virginia.edu,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vme: vme.c: fixed an EXPORT_SYMBOL warning
Date: Tue, 25 May 2010 06:44:53 -0700 [thread overview]
Message-ID: <20100525134453.GA4818@suse.de> (raw)
In-Reply-To: <1274792957-4602-1-git-send-email-nanakos@wired-net.gr>
On Tue, May 25, 2010 at 01:09:17PM +0000, nanakos@wired-net.gr wrote:
> From: Nanakos Chrysostomos <nanakos@wired-net.gr>
>
> Fixed an EXPORT_SYMBOL warning.
What type of warning? a checkpatch.pl one? a gcc one? a sparse one?
Please be more verbose.
> Signed-off-by: Nanakos Chrysostomos <nanakos@wired-net.gr>
> ---
> drivers/staging/vme/vme.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 093fbff..a0b63d5 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1519,7 +1519,6 @@ struct bus_type vme_bus_type = {
> .probe = vme_bus_probe,
> .remove = vme_bus_remove,
> };
> -EXPORT_SYMBOL(vme_bus_type);
>
> static int __init vme_init(void)
> {
> @@ -1530,6 +1529,7 @@ static void __exit vme_exit(void)
> {
> bus_unregister(&vme_bus_type);
> }
> +EXPORT_SYMBOL(vme_bus_type);
This does not look correct, why move this away from where the structure
is defined?
confused,
greg k-h
next prev parent reply other threads:[~2010-05-25 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 13:09 [PATCH] Staging: vme: vme.c: fixed an EXPORT_SYMBOL warning nanakos
2010-05-25 13:44 ` Greg KH [this message]
2010-05-25 14:19 ` Martyn Welch
2010-05-25 14:58 ` Greg KH
2010-05-25 15:06 ` Nanakos Chrysostomos
2010-05-25 15:24 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525134453.GA4818@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@ge.com \
--cc=nanakos@wired-net.gr \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox