From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758202Ab0EYNpd (ORCPT ); Tue, 25 May 2010 09:45:33 -0400 Received: from cantor.suse.de ([195.135.220.2]:59119 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758020Ab0EYNp3 (ORCPT ); Tue, 25 May 2010 09:45:29 -0400 Date: Tue, 25 May 2010 06:44:53 -0700 From: Greg KH To: nanakos@wired-net.gr Cc: martyn.welch@ge.com, wfp5p@virginia.edu, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: vme: vme.c: fixed an EXPORT_SYMBOL warning Message-ID: <20100525134453.GA4818@suse.de> References: <1274792957-4602-1-git-send-email-nanakos@wired-net.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1274792957-4602-1-git-send-email-nanakos@wired-net.gr> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2010 at 01:09:17PM +0000, nanakos@wired-net.gr wrote: > From: Nanakos Chrysostomos > > Fixed an EXPORT_SYMBOL warning. What type of warning? a checkpatch.pl one? a gcc one? a sparse one? Please be more verbose. > Signed-off-by: Nanakos Chrysostomos > --- > drivers/staging/vme/vme.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c > index 093fbff..a0b63d5 100644 > --- a/drivers/staging/vme/vme.c > +++ b/drivers/staging/vme/vme.c > @@ -1519,7 +1519,6 @@ struct bus_type vme_bus_type = { > .probe = vme_bus_probe, > .remove = vme_bus_remove, > }; > -EXPORT_SYMBOL(vme_bus_type); > > static int __init vme_init(void) > { > @@ -1530,6 +1529,7 @@ static void __exit vme_exit(void) > { > bus_unregister(&vme_bus_type); > } > +EXPORT_SYMBOL(vme_bus_type); This does not look correct, why move this away from where the structure is defined? confused, greg k-h