Re: [PATCH] Staging: vme: vme.c: fixed an EXPORT_SYMBOL warning

[Greg KH <gregkh@suse.de>]

On Tue, May 25, 2010 at 03:19:32PM +0100, Martyn Welch wrote:
> Greg KH wrote:
> > On Tue, May 25, 2010 at 01:09:17PM +0000, nanakos@wired-net.gr wrote:
> >   
> >> From: Nanakos Chrysostomos <nanakos@wired-net.gr>
> >>
> >> Fixed an EXPORT_SYMBOL warning.
> >>     
> >
> > What type of warning?  a checkpatch.pl one?  a gcc one?  a sparse one?
> >
> > Please be more verbose.
> >
> >   
> >> Signed-off-by: Nanakos Chrysostomos <nanakos@wired-net.gr>
> >> ---
> >>  drivers/staging/vme/vme.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> >> index 093fbff..a0b63d5 100644
> >> --- a/drivers/staging/vme/vme.c
> >> +++ b/drivers/staging/vme/vme.c
> >> @@ -1519,7 +1519,6 @@ struct bus_type vme_bus_type = {
> >>  	.probe = vme_bus_probe,
> >>  	.remove = vme_bus_remove,
> >>  };
> >> -EXPORT_SYMBOL(vme_bus_type);
> >>  
> >>  static int __init vme_init(void)
> >>  {
> >> @@ -1530,6 +1529,7 @@ static void __exit vme_exit(void)
> >>  {
> >>  	bus_unregister(&vme_bus_type);
> >>  }
> >> +EXPORT_SYMBOL(vme_bus_type);
> >>     
> >
> > This does not look correct, why move this away from where the structure
> > is defined?
> >
> >   
> 
> It's a checkpatch error:
> 
> $ scripts/checkpatch.pl -f drivers/staging/vme/vme.c
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #1522: FILE: staging/vme/vme.c:1522:
> +EXPORT_SYMBOL(vme_bus_type);

We should fix checkpatch.pl, as this looks like a bug in it, not the
source code here.

thanks,

greg k-h