From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Will Drewry <wad@chromium.org>,
Alasdair G Kergon <agk@redhat.com>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Nick Piggin <npiggin@suse.de>, Tejun Heo <tj@kernel.org>,
Scott James Remnant <scott@ubuntu.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Harald Hoyer <harald@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 2/2] init, mount: export the name_to_dev_t symbol
Date: Tue, 25 May 2010 14:30:51 -0400 [thread overview]
Message-ID: <20100525183051.GA692@redhat.com> (raw)
In-Reply-To: <20100525172110.GA6046@infradead.org>
On Tue, May 25 2010 at 1:21pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, May 25, 2010 at 11:11:33AM -0500, Will Drewry wrote:
> > In addition to getting rid of the code duplication, I'd like device-mapper
> > to be able to resolve slave devices at boot-time to accommodate a
> > do_mounts_dm.c equivalent to do_mounts_md.c:
>
> So please add a do_mounts_dm.c instead of pushing this somewhere it
> doesn't belong to.
He is proposing doing just that, you cut out the patchwork url he
already shared: https://patchwork.kernel.org/patch/101024/
Will's intentions are good: avoid code duplication.
He is also trying to keep DM-specific common code in drivers/md/
So in this instance, avoiding the need to export name_to_dev_t would
require splitting the internal DM __table_get_device (or more likely:
dm_get_device) out to a public facing interface that takes a dev_t.
Mike
next prev parent reply other threads:[~2010-05-25 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 15:46 [PATCH 1/2] init: make the path argument a const in name_to_dev_t Will Drewry
2010-05-25 15:46 ` [PATCH 2/2] init, mount: export the name_to_dev_t symbol Will Drewry
2010-05-25 15:55 ` Christoph Hellwig
2010-05-25 16:05 ` Alasdair G Kergon
2010-05-25 16:11 ` Will Drewry
2010-05-25 17:21 ` Christoph Hellwig
2010-05-25 18:30 ` Mike Snitzer [this message]
2010-06-08 16:02 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525183051.GA692@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=cl@linux-foundation.org \
--cc=harald@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=scott@ubuntu.com \
--cc=tj@kernel.org \
--cc=vegard.nossum@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox