linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Jie Zhang <jie@codesourcery.com>,
	uclinux-dev@uclinux.org, David Howells <dhowells@redhat.com>,
	David McCullough <davidm@snapgear.com>,
	Greg Ungerer <gerg@uclinux.org>,
	uclinux-dist-devel@blackfin.uclinux.org,
	microblaze-uclinux@itee.uq.edu.au,
	Michal Simek <monstr@monstr.eu>,
	linux-m32r@ml.linux-m32r.org,
	Hirokazu Takata <takata@linux-m32r.org>,
	linux-kernel@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] FLAT: allow arches to declare a larger alignment than the slab
Date: Wed, 26 May 2010 16:33:34 +0900	[thread overview]
Message-ID: <20100526073334.GD26696@linux-sh.org> (raw)
In-Reply-To: <AANLkTimWuqtLtnrgA8SHa-XoN8YdHJhQ6F2BngmmKSrl@mail.gmail.com>

On Wed, May 26, 2010 at 03:23:02AM -0400, Mike Frysinger wrote:
> On Wed, May 26, 2010 at 02:59, Geert Uytterhoeven wrote:
> > From looking at <linux/flat.h>, it looks like the FLAT binary format
> > doesn't contain any
> > alignment information? So if I put __attribute__((aligned(4096))) in a
> > file, there's still
> > no guarantee it will actually be in memory at a 4Ki-aligned address?
> 
> i believe that is correct.  FLAT behavior today provides alignment of
> either sizeof(unsigned long) or ARCH_SLAB_MINALIGN.
> 
> i imagine something like this would work today because everyone
> defines it to a constant:
> -#ifdef ARCH_SLAB_MINALIGN
> +#if defined(ARCH_SLAB_MINALIGN) && ARCH_SLAB_MINALIGN != 0
> but this would break if someone tried using gcc sizeof/alignof/etc...

alignof is used by SLUB/SLOB to set the ARCH_SLAB_MINALIGN value if the
architecture hasn't already specified one, so that wouldn't work.

  reply	other threads:[~2010-05-26  7:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 19:24 [PATCH] FLAT: allow arches to declare a larger alignment than the slab Mike Frysinger
2010-05-25 19:50 ` Geert Uytterhoeven
2010-05-25 21:07 ` Paul Mundt
2010-05-25 23:17   ` Mike Frysinger
2010-05-26  2:23     ` Jie Zhang
2010-05-26  6:59       ` Geert Uytterhoeven
2010-05-26  7:23         ` Mike Frysinger
2010-05-26  7:33           ` Paul Mundt [this message]
2010-05-26  7:36             ` Mike Frysinger
2010-05-26  7:36       ` Mike Frysinger
2010-05-26  7:48     ` Paul Mundt
2010-05-26  8:01       ` Mike Frysinger
2010-05-26  7:24 ` Michal Simek
2010-05-26  8:45 ` [PATCH 1/2 v2] FLAT: split the stack & data alignments Mike Frysinger
2010-05-27  8:24   ` Michal Simek
2010-05-27 18:30     ` [Uclinux-dist-devel] " Mike Frysinger
2010-05-27 23:15       ` [microblaze-uclinux] " David McCullough
2010-05-28  4:57         ` Mike Frysinger
2010-05-28  6:05   ` Mike Frysinger
2010-05-28  6:23   ` David McCullough
2010-05-28  6:40   ` Greg Ungerer
2010-05-26  8:45 ` [PATCH 2/2 v2] FLAT: tweak default stack alignment Mike Frysinger
2010-05-28  6:24   ` David McCullough
2010-05-28  6:39   ` Greg Ungerer
2010-06-06  7:12   ` [PATCH v3] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526073334.GD26696@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=davidm@snapgear.com \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=jie@codesourcery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m32r@ml.linux-m32r.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=monstr@monstr.eu \
    --cc=takata@linux-m32r.org \
    --cc=uclinux-dev@uclinux.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier.adi@gmail.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).