From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
David Miller <davem@davemloft.net>,
Paul Mundt <lethal@linux-sh.org>,
Will Deacon <will.deacon@arm.com>,
Deng-Cheng Zhu <dengcheng.zhu@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] convert perf to local64_t
Date: Wed, 26 May 2010 12:08:48 +0200 [thread overview]
Message-ID: <20100526100844.GB5311@nowhere> (raw)
In-Reply-To: <20100521134205.781916350@chello.nl>
On Fri, May 21, 2010 at 03:42:05PM +0200, Peter Zijlstra wrote:
> These patches introduce local64_t.
>
> Since perf_event:count is only modified cross-cpu when child-counters
> feed back their changes on exit, and we can use a secondary variable
> for that, we can convert perf to use local64_t instead of atomic64_t
> and use instructions without buslock semantics.
>
> The local64_t implementation uses local_t for 64 bits, since local_t is
> of type long, for 32 bit it falls back to atomic64_t. Architectures can
> provide their own implementation as usual.
It seems nobody disagrees with it. Can we give it a try?
Thanks.
next prev parent reply other threads:[~2010-05-26 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 13:42 [PATCH 0/4] convert perf to local64_t Peter Zijlstra
2010-05-21 13:42 ` [PATCH 1/4] arch: local64_t Peter Zijlstra
2010-05-21 14:47 ` Kyle McMartin
2010-05-21 14:52 ` David Howells
2010-05-21 13:42 ` [PATCH 2/4] perf: Add perf_event_count() Peter Zijlstra
2010-05-21 13:42 ` [PATCH 3/4] perf: Add child_count Peter Zijlstra
2010-05-21 13:42 ` [PATCH 4/4] perf: Convert perf_event to local_t Peter Zijlstra
2010-05-26 10:08 ` Frederic Weisbecker [this message]
2010-05-26 10:11 ` [PATCH 0/4] convert perf to local64_t Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526100844.GB5311@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=dengcheng.zhu@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox