From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755127Ab0EZOxP (ORCPT ); Wed, 26 May 2010 10:53:15 -0400 Received: from cantor.suse.de ([195.135.220.2]:45931 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754812Ab0EZOxO (ORCPT ); Wed, 26 May 2010 10:53:14 -0400 Date: Wed, 26 May 2010 07:35:33 -0700 From: Greg KH To: David Miller Cc: ebiederm@xmission.com, error27@gmail.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] kobject: free memory if netlink_kernel_create() fails Message-ID: <20100526143533.GA5644@suse.de> References: <20100525095110.GG22515@bicker> <20100526.004347.115926528.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100526.004347.115926528.davem@davemloft.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 26, 2010 at 12:43:47AM -0700, David Miller wrote: > From: ebiederm@xmission.com (Eric W. Biederman) > Date: Tue, 25 May 2010 03:25:37 -0700 > > > Dan Carpenter writes: > > > >> There is a kfree(ue_sk) missing on the error path if > >> netlink_kernel_create() fails. > >> > >> Signed-off-by: Dan Carpenter > > Reviewed-by: "Eric W. Biederman" > > Greg, I assume you've got this one? Yes, I'll queue it up in a day or so. thanks, greg k-h