From: Yong Zhang <yong.zhang@windriver.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
monstr@monstr.eu, linux-kernel@vger.kernel.org,
michal.simek@petalogix.com, arnd@arndb.de,
john.williams@petalogix.com, tglx@linutronix.de,
peter.fritzsche@gmx.de, anton@samba.org, mingo@elte.hu,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq_save/restore
Date: Thu, 27 May 2010 17:11:26 +0800 [thread overview]
Message-ID: <20100527091126.GB14906@windriver.com> (raw)
In-Reply-To: <1274893911.22648.246.camel@gandalf.stny.rr.com>
On Wed, May 26, 2010 at 01:11:51PM -0400, Steven Rostedt wrote:
> On Wed, 2010-05-26 at 10:08 -0700, Andrew Morton wrote:
>
> >
> > If a developer looks at atomic_add_return() and asks himself "why did
> > this use raw_local_irq_save()", the only way of answering that question
> > is to go groveling through the git logs, which is a right PITA if
> > you're trying to get some coding work done.
> >
> > Guys, any time you add code which is non-obvious at the raw C level, it
> > *needs* a comment!
>
> Totally agree! I've gotten pretty good at adding comments to changes
> like this that I do. I need to get better at telling others to comment
> their work ;-)
Cc'ed Frederic Weisbecker
Seems like this issue has been raised before:
http://marc.info/?l=linux-kernel&m=126292794806169&w=2
I'm afraid this patch will trigger lockdep warning if atomic_inc()
is used in some locks.
next prev parent reply other threads:[~2010-05-27 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1274863724-14906-1-git-send-email-monstr@monstr.eu>
[not found] ` <1274863724-14906-2-git-send-email-monstr@monstr.eu>
2010-05-26 14:42 ` [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq_save/restore Steven Rostedt
2010-05-26 17:08 ` Andrew Morton
2010-05-26 17:11 ` Steven Rostedt
2010-05-27 7:14 ` Michal Simek
2010-05-27 9:11 ` Yong Zhang [this message]
2010-07-26 8:49 ` Michal Simek
2010-07-27 23:18 ` Andrew Morton
2010-07-27 23:54 ` Mike Frysinger
2010-07-28 5:23 ` Michal Simek
2010-07-28 5:20 ` Michal Simek
2010-07-28 5:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527091126.GB14906@windriver.com \
--to=yong.zhang@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@petalogix.com \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=peter.fritzsche@gmx.de \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox