From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
wezhang@redhat.com, linux-kernel@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
William Cohen <wcohen@redhat.com>
Subject: [PATCH 0/3] (Was: Q: sys_personality() && misc oddities)
Date: Thu, 27 May 2010 17:35:22 +0200 [thread overview]
Message-ID: <20100527153522.GA13858@redhat.com> (raw)
In-Reply-To: <20100526203105.59D7849A56@magilla.sf.frob.com>
On 05/26, Roland McGrath wrote:
>
> > Yes, libc itself is fine. But from the application's pov, personality()
> > returns int, not long.
>
> That doesn't really matter to error/success ambiguity. Since what I said
> is true, it won't ever return exactly -1 for a non-error. But even if it
> did, the application can use errno=0;personality(x);errno!=0 checking.
Agreed! to me this looks like the user-space bug, but there are people
who disagree.
Probably my initial email wasn't clear, I'll try to explain this better
in the changelog.
> > How about
> >
> > if (personality != 0xffffffff) {
> > if (personality >= 0x7fffffff)
> > return -EINVAL;
>
> Sure.
OK. Please see the patches.
1/3 - obviously makes sense to me
2/3 - not sure
3/3 - simple cleanup, doesn't depend on 1-2
Oleg.
next prev parent reply other threads:[~2010-05-27 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 14:17 Q: sys_personality() && misc oddities Oleg Nesterov
2010-05-25 19:33 ` Roland McGrath
2010-05-26 12:36 ` Oleg Nesterov
2010-05-26 20:31 ` Roland McGrath
2010-05-26 20:35 ` H. Peter Anvin
2010-05-27 15:35 ` Oleg Nesterov [this message]
2010-05-27 15:35 ` [PATCH 1/3] sys_personality: validate personality before set_personality() Oleg Nesterov
2010-05-27 16:39 ` Linus Torvalds
2010-05-27 17:15 ` Oleg Nesterov
2010-05-27 17:51 ` Linus Torvalds
2010-05-27 18:13 ` Oleg Nesterov
2010-05-27 18:18 ` Andi Kleen
2010-05-28 19:11 ` [PATCH 0/2] sys_personality fixes v2 Oleg Nesterov
2010-05-28 19:12 ` [PATCH 1/2] change sys_personality() to accept "unsigned int" instead of u_long Oleg Nesterov
2010-05-28 19:12 ` [PATCH 2/2] remove the bogus checks in sys_personality()->__set_personality() path Oleg Nesterov
2010-05-28 19:28 ` [PATCH 0/2] sys_personality fixes v2 Linus Torvalds
2010-05-28 19:58 ` H. Peter Anvin
2010-05-28 19:59 ` Oleg Nesterov
2010-05-27 15:36 ` [PATCH 2/3] sys_personality: make sure (int)personality >= 0 Oleg Nesterov
2010-05-27 20:02 ` H. Peter Anvin
2010-05-28 19:03 ` Oleg Nesterov
2010-05-27 15:36 ` [PATCH 3/3] __set_personality: no need to check the old ->exec_domain Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527153522.GA13858@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=roland@redhat.com \
--cc=rth@twiddle.net \
--cc=torvalds@linux-foundation.org \
--cc=wcohen@redhat.com \
--cc=wezhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).