From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com
Subject: Re: [PATCH] perf: fix use_browser infinite loop bug in annotate
Date: Thu, 27 May 2010 12:45:11 -0300 [thread overview]
Message-ID: <20100527154510.GK9874@ghostprotocols.net> (raw)
In-Reply-To: <20100527145142.GJ9874@ghostprotocols.net>
Em Thu, May 27, 2010 at 11:51:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
> > This patch fixes an infinite loop problem with perf annotate when
> > the TUI is not used. When the perfconfig file is not found use_browser
> > remains at -1, when found and tui is disabled use_browser = 0. Thus the
> > correct test for TUI is use_browser > 0.
> >
> > Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Thanks, I'm applying this one and doing an audit of other uses, I know
> of one more case reported by Frédéric that was fixed in a similar way.
Oops, I already have this fixed on changeset
62e3436b5f3461662929eae102beefbd12127cb1
That is at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf
http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=commit;h=62e3436b5f3461662929eae102beefbd12127cb1
I pushed this to Ingo yesterday, should be in tip/perf/core soon,
thanks anyway!
- Arnaldo
next prev parent reply other threads:[~2010-05-27 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 12:50 [PATCH] perf: fix use_browser infinite loop bug in annotate Stephane Eranian
2010-05-27 14:51 ` Arnaldo Carvalho de Melo
2010-05-27 15:45 ` Arnaldo Carvalho de Melo [this message]
2010-05-27 15:52 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527154510.GK9874@ghostprotocols.net \
--to=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox