From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423Ab0E1GoP (ORCPT ); Fri, 28 May 2010 02:44:15 -0400 Received: from ksp.mff.cuni.cz ([195.113.26.206]:37689 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752391Ab0E1GoM (ORCPT ); Fri, 28 May 2010 02:44:12 -0400 Date: Fri, 28 May 2010 08:43:57 +0200 From: Pavel Machek To: Arve Hj?nnev?g Cc: Tony Lindgren , Brian Swetland , Alan Stern , mark gross , markgross@thegnar.org, Len Brown , linux-doc@vger.kernel.org, Kernel development list , Jesse Barnes , Oleg Nesterov , Tejun Heo , Linux-pm mailing list , Wu Fengguang , Andrew Morton Subject: Re: [linux-pm] [PATCH 1/8] PM: Add suspend block api. Message-ID: <20100528064356.GA2455@ucw.cz> References: <20100505202826.GB7450@linux.intel.com> <20100505234755.GI29604@atomide.com> <20100506000552.GJ29604@atomide.com> <20100506170420.GB30928@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >> >> How often would we retry suspending? > >> > > >> > Well based on some timer, the same way the screen blanks? Or five > >> > seconds of no audio play? So if the suspend fails, then reset whatever > >> > userspace suspend policy timers. > >> > > >> >> If we fail to suspend, don't we have to resume all the drivers that > >> >> suspended before the one that failed?  (Maybe I'm mistaken here) > >> > > >> > Sure, but I guess that should be a rare event that only happens when > >> > you try to suspend and something interrupts the suspend. > >> > > >> > >> This is not a rare event. For example, the matrix keypad driver blocks > >> suspend when a key is down so it can scan the matrix. > > > > Sure, but how many times per day are you suspending? > > How many times we successfully suspend is irrelevant here. If the > driver blocks suspend the number of suspend attempts depend on your > poll frequency. Actually, this is quite interesting question I'd like answer here: "Sure, but how many times per day are you suspending?" I suspect it may be in 1000s, but it would be cool to get better answer -- so that people knew what we are talking about here. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html