From: Joerg Roedel <joro@8bytes.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Nicolas Palix <npalix@diku.dk>,
Randy Dunlap <rdunlap@xenotime.net>,
Roland Dreier <rdreier@cisco.com>, Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Michal Marek <mmarek@suse.cz>, Sam Ravnborg <sam@ravnborg.org>,
Julia Lawall <julia@diku.dk>,
Gilles Muller <Gilles.Muller@lip6.fr>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
cocci@diku.dk, Wolfram Sang <w.sang@pengutronix.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 1/4] Add targets to use the Coccinelle checker
Date: Fri, 28 May 2010 09:04:01 +0200 [thread overview]
Message-ID: <20100528070401.GJ1237@8bytes.org> (raw)
In-Reply-To: <20100512064230.GC5718@cr0.nay.redhat.com>
On Wed, May 12, 2010 at 02:42:30PM +0800, Américo Wang wrote:
> On Mon, May 10, 2010 at 06:24:24PM +0200, Nicolas Palix wrote:
> >Four targets are added. Each one generates a different
> >output kind: context, patch, org, report.
> >Every SmPL file in 'scripts/coccinelle' is given to the spatch frontend
> >(located in the 'scripts' directory), and applied to the entire
> >source tree.
> >
> >Signed-off-by: Nicolas Palix <npalix@diku.dk>
> >Signed-off-by: Julia Lawall <julia@diku.dk>
>
> This is great!
Totally agreed.
> I would like to see coccinelle to be integrated with kbuild, but the
> name 'coccicheck' is really confusing, how about 'sema_check'? Which
> means 'semantic check'.
I think its okay to keep coccicheck because its the name of the tool
called. We do the same with 'make cscope'.
But since I am a bit lazy I would prefer a shorter name, probably just
'make cocci'?
> Or we can use something like for sparse, i.e. 'make C=1' etc..
Yes, this would also make sense. As a developer I could add this and
only the code I changed is checked.
Joerg
next prev parent reply other threads:[~2010-05-28 7:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 16:24 [PATCH 0/4] Add a Coccinelle front-end script Nicolas Palix
2010-05-10 16:24 ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-05-12 6:42 ` Américo Wang
2010-05-28 7:04 ` Joerg Roedel [this message]
2010-06-03 9:50 ` Michal Marek
2010-06-03 10:23 ` Sam Ravnborg
2010-06-04 9:56 ` Nicolas Palix
2010-06-04 10:38 ` Sam Ravnborg
2010-05-10 16:24 ` [PATCH 2/4] Add scripts/coccinelle/drop_kmalloc_cast.cocci Nicolas Palix
2010-05-10 16:24 ` [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Nicolas Palix
2010-06-03 9:51 ` Michal Marek
2010-06-03 10:11 ` Nicolas Palix
2010-05-10 16:24 ` [PATCH 4/4] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-05-10 16:52 ` Pekka Enberg
2010-05-27 11:48 ` Nicolas Palix
2010-05-11 2:14 ` [PATCH 0/4] Add a Coccinelle front-end script Andy Isaacson
2010-05-17 9:31 ` Wolfram Sang
2010-05-28 7:09 ` Joerg Roedel
2010-05-28 7:25 ` Wolfram Sang
2010-05-28 7:31 ` Julia Lawall
2010-05-28 7:39 ` walter harms
2010-05-28 9:15 ` Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2010-04-26 21:11 Nicolas Palix
2010-04-26 21:11 ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-04-26 21:37 ` Joe Perches
2010-04-26 22:20 ` Nicolas Palix
2010-04-26 22:23 ` Randy Dunlap
2010-04-29 17:01 ` Roland Dreier
2010-04-30 21:07 ` Randy Dunlap
2010-04-27 12:40 ` Michal Marek
2010-04-27 13:01 ` Michal Marek
2010-04-27 12:53 ` Wolfram Sang
2010-04-27 20:24 ` Sam Ravnborg
2010-04-27 20:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528070401.GJ1237@8bytes.org \
--to=joro@8bytes.org \
--cc=Gilles.Muller@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=cocci@diku.dk \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=npalix@diku.dk \
--cc=rdreier@cisco.com \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=w.sang@pengutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).