From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756535Ab0E1IFq (ORCPT ); Fri, 28 May 2010 04:05:46 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:59332 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755853Ab0E1IFm (ORCPT ); Fri, 28 May 2010 04:05:42 -0400 Date: Fri, 28 May 2010 10:05:31 +0200 From: Ingo Molnar To: David Miller Cc: eric.dumazet@gmail.com, torvalds@linux-foundation.org, tglx@linutronix.de, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: boot crash in arp_error_report() Message-ID: <20100528080531.GA9893@elte.hu> References: <1274989637.2446.1.camel@edumazet-laptop> <1274991504.2446.13.camel@edumazet-laptop> <20100527.161011.104042698.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100527.161011.104042698.davem@davemloft.net> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0007] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * David Miller wrote: > From: Eric Dumazet > Date: Thu, 27 May 2010 22:18:24 +0200 > > > [PATCH] net: fix __neigh_event_send() > > > > commit 7fee226ad23 (net: add a noref bit on skb dst) missed one spot > > where an skb is enqueued, with a possibly not refcounted dst entry. > > > > __neigh_event_send() inserts skb into arp_queue, so we must make sure > > dst entry is refcounted, or dst entry can be freed by garbage collector > > after caller exits from rcu protected section. > > > > Reported-by: Ingo Molnar > > Signed-off-by: Eric Dumazet > > Applied, thanks Eric. > > Ingo can we get a confirmation that this fixes the bootup crash? Sure, will let you know how it goes. Thanks, Ingo