From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043Ab0E1M5y (ORCPT ); Fri, 28 May 2010 08:57:54 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:48080 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779Ab0E1M5x (ORCPT ); Fri, 28 May 2010 08:57:53 -0400 Date: Fri, 28 May 2010 09:57:29 -0300 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com, perfmon2-devel@lists.sf.net, eranian@gmail.com, tzanussi@gmail.com, Arun Sharma Subject: Re: [PATCH] perf: make perf report -D print sampled CPU Message-ID: <20100528125728.GP9874@ghostprotocols.net> References: <4bff964c.e88cd80a.3106.7d31@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bff964c.e88cd80a.3106.7d31@mx.google.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 28, 2010 at 12:08:01PM +0200, Stephane Eranian escreveu: > It is useful to know on which CPU a sample was captured on. > The information is captured with perf record -R but it was > not printed out by perf report -D. This patch adds this. > > When -R is not used, cpu is set to -1to indicate that > the CPU is unknown (it is not captured). > > Signed-off-by: Stephane Eranian It conflicts with Arun's patch for sorting by CPU that I started playing with yesterday, but in a good way, i.e. printing the CPU at that dump_printf spot was one of the changs I made in Arun's patch as well. [root@emilia linux-2.6-tip]# perf report -D | grep SAMPLE | head -6 0x10240 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff81253362 period: 1894446 0x10268 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff81253338 period: 1894446 0x10290 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff8125300d period: 1905103 0x102b8 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 0/0: 0xffffffff8109117d period: 1838260 0x102e0 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 293/293: 0xffffffff8101ace6 period: 352697 0x10308 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 1763/1763: 0xffffffff8101ace6 period: 352697 [root@emilia linux-2.6-tip]# I added it just before the pid/tid but prefixing it with "cpu: " is as good as doing it that way. I'm applying both patches after some tests, Thanks! - Arnaldo