From: Andrew Morton <akpm@linux-foundation.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card()
Date: Fri, 28 May 2010 14:40:27 -0700 [thread overview]
Message-ID: <20100528144027.3c868841.akpm@linux-foundation.org> (raw)
In-Reply-To: <1-1000-12432-1274803827-7569@rere.qmqm.pl>
On Tue, 25 May 2010 18:10:28 +0200 (CEST)
Micha__ Miros__aw <mirq-linux@rere.qmqm.pl> wrote:
> This is needed to avoid code duplication in SD-combo support.
hm. Perhaps you could have told us a bit more about it than this.
> +int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid)
> +int mmc_sd_get_csd(struct mmc_host *host, struct mmc_card *card)
> +int mmc_sd_setup_card(struct mmc_host *host, struct mmc_card *card,
> +unsigned mmc_sd_get_max_clock(struct mmc_card *card)
> +void mmc_sd_go_highspeed(struct mmc_card *card)
These are global symbols, but they are not exported to (other) modules.
That's odd. I'd have expected to see them either `static' or
EXPORT_MODULE()d.
I'll take the lack of a signed-off-by: and the "RFC" as signal to not
apply these patches.
next prev parent reply other threads:[~2010-05-28 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 16:10 [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card() Michał Mirosław
2010-05-25 16:10 ` [RFC] [PATCH 2/2] mmc: implement SD-combo (IO+mem) support Michał Mirosław
2010-05-28 21:51 ` Andrew Morton
2010-05-28 21:40 ` Andrew Morton [this message]
2010-05-31 15:58 ` [RFC] [PATCH 1/2] mmc: split mmc_sd_init_card() Michał Mirosław
2010-06-03 9:23 ` Adrian Hunter
2010-06-03 17:21 ` Chris Ball
2010-06-03 18:37 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528144027.3c868841.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox