From: Oliver Neukum <oneukum@suse.de>
To: "Александр Мурашов" <alex_mur_spb@mail.ru>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 0001-This-is-a-patch-to-the-gen-devlist.c-file-that-fixes.patch
Date: Fri, 28 May 2010 18:13:16 +0200 [thread overview]
Message-ID: <201005281813.16612.oneukum@suse.de> (raw)
In-Reply-To: <E1OI0Jf-0003LU-00.alex_mur_spb-mail-ru@f10.mail.ru>
Am Freitag, 28. Mai 2010 16:13:39 schrieb Александр Мурашов:
>
> This is my first patch.Do not judge me harshly, I'm just learning.
I am afraid the first segment creates invalid C.
In addition, even the rules of coding style have to be applied
with some common sense. Otherwise the result is basically unreadable.
Regards
Oliver
prev parent reply other threads:[~2010-05-28 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 14:13 0001-This-is-a-patch-to-the-gen-devlist.c-file-that-fixes.patch Александр Мурашов
2010-05-28 16:13 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005281813.16612.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=alex_mur_spb@mail.ru \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox