From: Andi Kleen <andi@firstfloor.org>
To: TAMUKI Shoichi <tamuki@linet.gr.jp>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Anton Blanchard <anton@samba.org>, Andy Green <andy@warmcat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: keep blinking in spite of long spin timer mode
Date: Sun, 30 May 2010 08:55:22 +0200 [thread overview]
Message-ID: <20100530065522.GA14556@basil.fritz.box> (raw)
In-Reply-To: <201005282211.AA00413@tamuki.linet.gr.jp>
> Therefore, I changed to call panic_blink_enter() between every mdelay.
> The default time calls to mdelay is 1ms. If the kernel parameter
> panic_longspin is set to true, it will be switched to 240ms and the
> maximum speed of blinking will be automatically limited slower due to
> the granularity of the blinking time.
Thanks for this explanation, makes all sense.
But should do these changes by default then, not with a parameter.
Changing the frequency is ok, the only requirement is that it is
visible and different from the frequency kdb uses.
-Andi
next prev parent reply other threads:[~2010-05-30 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 21:56 [PATCH] panic: keep blinking in spite of long spin timer mode TAMUKI Shoichi
2010-05-28 9:13 ` Andi Kleen
2010-05-28 22:11 ` TAMUKI Shoichi
2010-05-30 6:55 ` Andi Kleen [this message]
2010-06-02 21:57 ` TAMUKI Shoichi
2010-05-28 22:22 ` Randy Dunlap
2010-05-30 21:58 ` TAMUKI Shoichi
2010-06-02 18:34 ` Andrew Morton
2010-06-03 21:49 ` TAMUKI Shoichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530065522.GA14556@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=andy@warmcat.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tamuki@linet.gr.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).