From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Exclude DAHDI devices from being probed by netjet
Date: Sun, 30 May 2010 15:07:37 +0100 [thread overview]
Message-ID: <20100530150737.52bc342a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20100529232946.GA1748@xorcom.com>
> 2. I don't have more precise data than the PCI ID tables in the drivers.
> Does this run the risk of excluding some actual Netjet ISDN cards?
Is there a reason you are seeing so many different vendor values - surely
you should see a single 'Digium' subvendor, and various subdevice values ?
> + switch (pdev->subsystem_vendor) {
> + /* Fall-through */
> + case 0x2151: /* Yeastart YSTDM8xx (ystdm8xx) */
> + case 0xe16b: /* Zapata Project PCI-Radio (pciradio) */
> + case 0x6159: /* Digium Wildcard T100/E100 (wct1xxp) */
> + case 0x71fe: /* Digium Wildcard TE110P (wcte1xp) */
> + case 0x795e: /* Digium Wildcard TE110P (wcte1xp) */
> + case 0x797e: /* Digium Wildcard TE110P (wcte1xp) */
> + case 0x79de: /* Digium Wildcard TE110P (wcte1xp) */
> + case 0x79df: /* Digium Wildcard TE110P (wcte1xp) */
> + case 0x8084: /* Digium Wildcard X101P clone (wcfxo) */
> + case 0x8085: /* Digium Wildcard X101P (wcfxo) */
> + case 0x8086: /* Digium Wildcard X101P clone (wcfxo) */
> + case 0x8087: /* Digium Wildcard X101P clone (wcfxo) */
> + case 0xa800: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xa801: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xa8fd: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xa901: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xa908: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xa9fd: /* Digium Wildcard TDM400P Rev H (wctdm) */
> + case 0xb100: /* Digium Wildcard TDM400P Rev E/F (wctdm) */
> + case 0xb118: /* Digium Wildcard TDM400P Rev I (wctdm) */
> + case 0xb119: /* Digium Wildcard TDM400P Rev I (wctdm) */
> + case 0xb1d9: /* Digium Wildcard TDM400P Rev I (wctdm) */
> + case 0xa159: /* Digium Wildcard S400P Prototype (wctdm) */
> + case 0xe159: /* Digium Wildcard S400P Prototype (wctdm) */
That might be better as a table. You can then als include the name and
match details in the report which will help diagnose problems with it eg
struct whatever {
u16 svid, sdid;
const char *name;
}
And then print
netjet: %s card is not supported by this driver (%04X, %04X).\n",
name, svid, sdid
Then again we don't seem to have a driver for these other kernel devices
so perhaps the safe default would be to warn and continue unless a module
option is set. At least initially.
Alan
prev parent reply other threads:[~2010-05-30 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 23:29 [PATCH] Exclude DAHDI devices from being probed by netjet Tzafrir Cohen
2010-05-30 14:07 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530150737.52bc342a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tzafrir.cohen@xorcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox