From: Arjan van de Ven <arjan@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: Documentation/timers/hpet_example.c compile bug
Date: Sun, 30 May 2010 20:10:24 -0700 [thread overview]
Message-ID: <20100530201024.061537a9@infradead.org> (raw)
In-Reply-To: <4C0325DE.6020604@oracle.com>
On Sun, 30 May 2010 19:58:38 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 05/30/10 19:49, Arjan van de Ven wrote:
> > On Sun, 30 May 2010 19:34:35 -0700
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >>
> >> Does it even make sense to build hpet_example on s390?
> >> I.e., does s390 have hpet?
> >> If not, then a simple Kconfig "depends on X86" or "depends
> >> on !S390" will fix this.
> >
> > HPET is very PC specific.
> >
> > but.. even on x86, it does not really make sense, and exposing this
> > as an interface to userspace is a historical mistake, the use of
> > which we really ought to discourage.
>
> Do you mean exposing anything that is in /usr/include/linux/hpet.h
> via ioctls? especially struct hpet_info ?
exposing even the concept of HPET, so yeah, including that header.
not all systems have hpet.. and frankly, we have better interfaces for
the same functionality...
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2010-05-31 3:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 11:35 Documentation/timers/hpet_example.c compile bug Heiko Carstens
2010-05-29 18:41 ` Randy Dunlap
2010-05-31 2:34 ` Randy Dunlap
2010-05-31 2:49 ` Arjan van de Ven
2010-05-31 2:58 ` Randy Dunlap
2010-05-31 3:10 ` Arjan van de Ven [this message]
2010-06-01 2:30 ` [PATCH] Documentation/timers/hpet_example.c: only build on X64 Randy Dunlap
2010-06-01 15:55 ` Linus Torvalds
2010-06-01 16:55 ` [PATCH v2] Documentation/timers/hpet_example.c: only build on X86 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530201024.061537a9@infradead.org \
--to=arjan@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox