public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: daniel@caiaq.de
Cc: linux-kernel@vger.kernel.org, tj@kernel.org, jkosina@suse.cz,
	cl@linux-foundation.org, joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/arcnet/capmode.c: clean up code
Date: Mon, 31 May 2010 00:35:39 -0700 (PDT)	[thread overview]
Message-ID: <20100531.003539.200382257.davem@davemloft.net> (raw)
In-Reply-To: <1275291070-23062-1-git-send-email-daniel@caiaq.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 736 bytes --]

From: Daniel Mack <daniel@caiaq.de>
Date: Mon, 31 May 2010 09:31:10 +0200

>  - shuffle around functions to get rid of forward declarations
>  - fix some CodingStyle and indentation issues
>  - last but not least, get rid of the following CONFIG_MODULE=n warning:
> 
> 	drivers/net/arcnet/capmode.c:52: warning: ¡capmode_proto¢ defined but not used
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>

Applied, but:

> +MODULE_LICENSE("GPL");
> +
> -- 
> 1.7.1
> 

Extraneous empty line at end of file, which GIT warned about.
I fixed it up before applying your patch.

Thanks.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2010-05-31  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 16:00 [PATCH] drivers/net/arcnet/capmode.c: clean up code Daniel Mack
2010-05-31  7:24 ` David Miller
2010-05-31  7:31   ` Daniel Mack
2010-05-31  7:35     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100531.003539.200382257.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cl@linux-foundation.org \
    --cc=daniel@caiaq.de \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox