From: Paul Mundt <lethal@linux-sh.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: Fix deferred console messages during CPU hotplug
Date: Mon, 31 May 2010 13:41:45 +0900 [thread overview]
Message-ID: <20100531044144.GA20358@linux-sh.org> (raw)
In-Reply-To: <526fcbfa605500d9da9b04ac0f93ef2beddca6ed@localhost.localdomain>
On Sun, May 30, 2010 at 12:35:58AM -0700, Kevin Cernekee wrote:
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 6cdca19..bf8923f 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -219,6 +220,10 @@ int __cpuinit __cpu_up(unsigned int cpu)
>
> cpu_set(cpu, cpu_online_map);
>
> + /* Flush out any buffered log messages from the new CPU */
> + if (try_acquire_console_sem() == 0)
> + release_console_sem();
> +
> return 0;
> }
>
Since this is entirely generic why not just have kernel/printk.c register
a hotcpu notifier and handle this in the CPU_ONLINE case?
next prev parent reply other threads:[~2010-05-31 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 7:32 [PATCH 1/2] MIPS: pfn_valid() is broken on low memory HIGHMEM systems Kevin Cernekee
2010-05-30 7:35 ` [PATCH 2/2] MIPS: Fix deferred console messages during CPU hotplug Kevin Cernekee
2010-05-31 4:41 ` Paul Mundt [this message]
2011-05-19 11:48 ` [PATCH 1/2] MIPS: pfn_valid() is broken on low memory HIGHMEM systems Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531044144.GA20358@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox