public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tracing: Add task activate/deactivate tracepoints
Date: Mon, 31 May 2010 10:00:49 +0200	[thread overview]
Message-ID: <20100531080049.GA435@elte.hu> (raw)
In-Reply-To: <1275059710.27810.9624.camel@twins>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2010-05-28 at 16:26 +0200, Frederic Weisbecker wrote:
> > We have various tracepoints that tell us when a task is going to
> > be enqueued in a runqueue: fork, wakeup, migrate.
> > 
> > But they don't always provide us the level of information necessary
> > to know what is actually in which runqueue, precisely because the
> > migrate event is only fired if the task is queued on another
> > cpu than its previous one. So we don't always know where a waking up
> > task goes.
> > 
> > And moreover we don't have events that tells a task goes to sleep,
> > and even that wouldn't cover every cases when a task is dequeued.
> > 
> > So bring these two new tracepoints to get informations about the
> > load of each runqueues.
> 
> NAK, aside from a few corner cases wakeup and sleep are the important 
> points.
> 
> The activate and deactivate functions are implementation details.

Frederic, can you show us a concrete example of where we dont know what is 
going on due to inadequate instrumentation? Can we fix that be extending the 
existing tracepoints?

	Ingo

  reply	other threads:[~2010-05-31  8:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 14:26 [PATCH] tracing: Add task activate/deactivate tracepoints Frederic Weisbecker
2010-05-28 15:15 ` Peter Zijlstra
2010-05-31  8:00   ` Ingo Molnar [this message]
2010-05-31  8:12     ` Peter Zijlstra
2010-05-31  8:54       ` Peter Zijlstra
2010-05-31 14:36         ` Frederic Weisbecker
2010-05-31 14:43           ` Peter Zijlstra
2010-05-31 14:48             ` Frederic Weisbecker
2010-05-31 16:18               ` Peter Zijlstra
2010-05-31 16:37                 ` Steven Rostedt
2010-05-31 18:28                   ` Peter Zijlstra
2010-05-31 19:14                     ` Steven Rostedt
2010-05-31 19:16                     ` Steven Rostedt
2010-05-31 16:51                 ` Frederic Weisbecker
2010-06-01  9:13                 ` [tip:sched/urgent] sched, trace: Fix sched_switch() prev_state argument tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100531080049.GA435@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox