Re: [PATCH] x86, hweight: Fix UML boot crash

[Borislav Petkov <borislav.petkov@amd.com>]

From: Toralf Förster <toralf.foerster@gmx.de>
Date: Mon, May 31, 2010 at 09:55:53AM -0400

> Borislav Petkov wrote at 22:17:38
> > LKML-Reference: <201005271944.09541.toralf.foerster@gmx.de>
> > Signed-off-by: Borislav Petkov <bp@alien8.de>
> > ---
> >  arch/um/include/asm/arch_hweight.h |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/um/include/asm/arch_hweight.h
> > 
> > diff --git a/arch/um/include/asm/arch_hweight.h b/arch/um/include/asm/arch_hweight.h
> > new file mode 100644
> > index 0000000..c656cf4
> > --- /dev/null
> > +++ b/arch/um/include/asm/arch_hweight.h
> > @@ -0,0 +1,6 @@
> > +#ifndef _ASM_UM_HWEIGHT_H
> > +#define _ASM_UM_HWEIGHT_H
> > +
> > +#include <asm-generic/bitops/arch_hweight.h>
> > +
> > +#endif
> > 
> This patch does not to solve the reported issue by me.

Did you do 'make mrproper' before rebuilding UML with it?

Also, can you do

grep -EriIn 'x86.*hweight\.h' arch/um/

after having applied the patch?

You shouldn't be getting any matches. If it still fails then, then it is
something else since with this patch, UML includes the standard hweight*
routines.

-- 
Regards/Gruss,
Boris.

Operating Systems Research Center
Advanced Micro Devices, Inc.