From: Philippe De Muyter <phdm@macqel.be>
To: Claudio Scordino <claudio@evidence.eu.com>
Cc: hskinnemoen@atmel.com, "Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Bernhard Roth" <br@pwrnet.de>, "Rick Bronson" <rick@efn.org>,
"John Nicholls" <john@thinlinx.com>,
"Sebastian Heutling" <Sebastian.Heutling@who-ing.de>,
"Ryan Mallon" <ryan@bluewatersys.com>,
"michael trimarchi" <michael@evidence.eu.com>,
"Konrad Mattheis" <mattheis@ukma.de>,
Elektrolot <elektrolot@wp.pl>,
"Prchal Jiří" <jiri.prchal@aksignal.cz>,
akpm@linux-foundation.org,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux@maxim.org.za
Subject: Re: [PATCH] General fixes in the serial_rs485 structure
Date: Mon, 31 May 2010 16:21:23 +0200 [thread overview]
Message-ID: <20100531142122.GA2571@frolo.macqel> (raw)
In-Reply-To: <4C03BC19.5060402@evidence.eu.com>
On Mon, May 31, 2010 at 03:39:37PM +0200, Claudio Scordino wrote:
> diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
> index eed3c2d..1adb1bf 100644
> --- a/drivers/serial/atmel_serial.c
> +++ b/drivers/serial/atmel_serial.c
> @@ -216,7 +216,7 @@ void atmel_config_rs485(struct uart_port *port, struct serial_rs485 *rs485conf)
> if (rs485conf->flags & SER_RS485_ENABLED) {
> dev_dbg(port->dev, "Setting UART to RS485\n");
> atmel_port->tx_done_mask = ATMEL_US_TXEMPTY;
> - UART_PUT_TTGR(port, rs485conf->delay_rts_before_send);
> + UART_PUT_TTGR(port, rs485conf->delay_rts_after_send);
> mode |= ATMEL_US_USMODE_RS485;
> } else {
> dev_dbg(port->dev, "Setting UART to RS232\n");
Should the usage of delay_rts_after_send not depend on
(flags & SER_RS485_RTS_AFTER_SEND) also ?
and likewise with delay_rts_before_send and SER_RS485_RTS_BEFORE_SEND ?
Philippe
--
Philippe De Muyter phdm at macqel dot be Tel +32 27029044
Macq Electronique SA rue de l'Aeronef 2 B-1140 Bruxelles Fax +32 27029077
next prev parent reply other threads:[~2010-05-31 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BFE66CA.5050500@evidence.eu.com>
[not found] ` <20100529000839.158dedd3@lxorguk.ukuu.org.uk>
[not found] ` <4C0375C1.5030305@evidence.eu.com>
[not found] ` <20100531113429.5efd6de9@lxorguk.ukuu.org.uk>
2010-05-31 13:39 ` [PATCH] General fixes in the serial_rs485 structure Claudio Scordino
2010-05-31 14:21 ` Philippe De Muyter [this message]
2010-05-31 15:21 ` Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531142122.GA2571@frolo.macqel \
--to=phdm@macqel.be \
--cc=Sebastian.Heutling@who-ing.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=br@pwrnet.de \
--cc=claudio@evidence.eu.com \
--cc=elektrolot@wp.pl \
--cc=hskinnemoen@atmel.com \
--cc=jiri.prchal@aksignal.cz \
--cc=john@thinlinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mattheis@ukma.de \
--cc=michael@evidence.eu.com \
--cc=nicolas.ferre@atmel.com \
--cc=rick@efn.org \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox