From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
herbert@gondor.hengli.com.au, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, agk@redhat.com, ak@linux.intel.com
Subject: Re: [PATCH] DM-CRYPT: Scale to multiple CPUs
Date: Mon, 31 May 2010 19:46:11 +0200 [thread overview]
Message-ID: <20100531174611.GF10766@basil.fritz.box> (raw)
In-Reply-To: <1275323695.3291.122.camel@edumazet-laptop>
On Mon, May 31, 2010 at 06:34:55PM +0200, Eric Dumazet wrote:
Yes seems like I'm behind on per cpu innovations.
> Since commit e0fdb0e050eae331, we have a __percpu annotation so that
> sparse can be augmented. This would also make the comment unnecessary...
I think the comment is still necessary.
>
> > + __get_cpu_var(io_wq_cpu) = current;
>
> this_cpu_write(io_wq_cpu, current)
And this one looks more ugly than before and does not seem
to generate better code, so I decided to skip it.
Thanks.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-05-31 17:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 16:04 [PATCH] DM-CRYPT: Scale to multiple CPUs Andi Kleen
2010-05-31 16:34 ` Eric Dumazet
2010-05-31 17:46 ` Andi Kleen [this message]
2010-05-31 17:52 ` Eric Dumazet
2010-05-31 17:22 ` [dm-devel] " Milan Broz
2010-05-31 17:42 ` Andi Kleen
2010-05-31 18:10 ` Milan Broz
2010-05-31 18:27 ` Andi Kleen
2010-05-31 18:55 ` Milan Broz
2010-05-31 19:04 ` Andi Kleen
2010-05-31 22:07 ` Herbert Xu
2010-06-01 1:46 ` huang ying
2010-06-01 2:39 ` Mikulas Patocka
2010-06-01 2:44 ` Mikulas Patocka
2010-06-01 4:39 ` Herbert Xu
2010-06-02 5:10 ` Mikulas Patocka
2010-06-02 5:14 ` Herbert Xu
2010-06-02 5:25 ` Mikulas Patocka
2010-06-02 6:07 ` Herbert Xu
2010-06-02 6:30 ` Steffen Klassert
2010-06-02 7:07 ` Herbert Xu
2010-06-02 7:51 ` Andi Kleen
2010-06-01 6:40 ` Andi Kleen
2010-06-02 5:15 ` Mikulas Patocka
2010-06-02 5:20 ` Herbert Xu
2010-06-02 7:53 ` Andi Kleen
2010-06-02 10:20 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2010-05-31 18:47 Tomasz Chmielewski
2010-06-01 7:21 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531174611.GF10766@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=agk@redhat.com \
--cc=ak@linux.intel.com \
--cc=dm-devel@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox