From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755212Ab0EaXL6 (ORCPT ); Mon, 31 May 2010 19:11:58 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56369 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635Ab0EaXL5 (ORCPT ); Mon, 31 May 2010 19:11:57 -0400 Date: Mon, 31 May 2010 20:11:45 -0300 From: Arnaldo Carvalho de Melo To: Valdis.Kletnieks@vt.edu Cc: Stephane Eranian , Ingo Molnar , linux-kernel@vger.kernel.org, "David S. Miller" , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Tom Zanussi Subject: Re: [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers Message-ID: <20100531231145.GA4093@ghostprotocols.net> References: <1274234900-12162-1-git-send-email-acme@infradead.org> <1274234900-12162-2-git-send-email-acme@infradead.org> <52092.1275333099@localhost> <77282.1275338942@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77282.1275338942@localhost> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, May 31, 2010 at 04:49:02PM -0400, Valdis.Kletnieks@vt.edu escreveu: > the same places, -B or not -B. I was sort of expecting that the first > example wouldn't have commas in it, or something? Or were those two Right, from a quick read it seems you saw a bug in the changeset and I saw none in the patch itself. I've read the intent, tested the patches, found it matched the intent, happily applied the patch with a confusing/wrong comment, too bad :-\ > examples *supposed* to be identical, and there's a not-shown 3rd example > that shows what you get if you use -B and set the LC_NUMERIC variable? - Arnaldo