From: Stephen Hemminger <shemminger@vyatta.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] squashfs: fix unsigned warnings
Date: Tue, 1 Jun 2010 09:14:01 -0700 [thread overview]
Message-ID: <20100601091401.0d927f09@nehalam> (raw)
In-Reply-To: <20100601091144.1ff3e677@nehalam>
The xattr_size is passed to xattr_lookup as a signed integer, when
it is unsigned. Also include xattr.h to get function prototype.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/fs/squashfs/xattr.h 2010-06-01 08:48:42.539735350 -0700
+++ b/fs/squashfs/xattr.h 2010-06-01 09:02:27.889738545 -0700
@@ -25,7 +25,7 @@
extern __le64 *squashfs_read_xattr_id_table(struct super_block *, u64,
u64 *, int *);
extern int squashfs_xattr_lookup(struct super_block *, unsigned int, int *,
- int *, unsigned long long *);
+ unsigned int *, unsigned long long *);
#else
static inline __le64 *squashfs_read_xattr_id_table(struct super_block *sb,
u64 start, u64 *xattr_table_start, int *xattr_ids)
@@ -35,7 +35,7 @@ static inline __le64 *squashfs_read_xatt
}
static inline int squashfs_xattr_lookup(struct super_block *sb,
- unsigned int index, int *count, int *size,
+ unsigned int index, int *count, unsigned int *size,
unsigned long long *xattr)
{
return 0;
--- a/fs/squashfs/xattr_id.c 2010-06-01 08:49:21.350077943 -0700
+++ b/fs/squashfs/xattr_id.c 2010-06-01 09:03:35.030052467 -0700
@@ -34,6 +34,7 @@
#include "squashfs_fs_sb.h"
#include "squashfs_fs_i.h"
#include "squashfs.h"
+#include "xattr.h"
/*
* Map xattr id using the xattr id look up table
prev parent reply other threads:[~2010-06-01 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 0:59 [GIT PULL] Squashfs updates for 2.6.35 Phillip Lougher
2010-05-29 14:21 ` Geert Uytterhoeven
2010-06-01 16:11 ` [PATCH 1/2] squashfs: xattr_handler don't inline Stephen Hemminger
2010-06-01 16:14 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601091401.0d927f09@nehalam \
--to=shemminger@vyatta.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox