From: mark gross <640e9920@gmail.com>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: markgross@thegnar.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
mark.gross@intel.com, Neil Brown <neilb@suse.de>,
Brian Swetland <swetland@google.com>,
linux-kernel@vger.kernel.org, Arve@smtp1.linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-pm@lists.linux-foundation.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [linux-pm] [RFC] lp_events: an lternitive to suspend blocker user mode and kernel API
Date: Tue, 1 Jun 2010 07:01:20 -0700 [thread overview]
Message-ID: <20100601140120.GB1281@gvim.org> (raw)
In-Reply-To: <AANLkTik4ixmtv5Ki7jds5gEspJAxBRAcJCR1Jv-V6ajR@mail.gmail.com>
On Mon, May 31, 2010 at 10:24:30PM -0700, Arve Hjønnevåg wrote:
> On Mon, May 31, 2010 at 10:09 PM, mark gross <640e9920@gmail.com> wrote:
> > On Tue, Jun 01, 2010 at 12:45:21AM +0200, Rafael J. Wysocki wrote:
> >> On Tuesday 01 June 2010, mark gross wrote:
> >> > On Mon, May 31, 2010 at 09:57:53AM +1000, Neil Brown wrote:
> >> ...
> >> > > So I would suggest modifying your proposal to simply create a new 'input'
> >> > > device. Any driver that supports wake-from-suspend queues an event to that
> >> > > device when a wakeup event occurs. If the device is open and has any queued
> >> > > events, then a suspend request such as 'echo mem > /sys/power/state' completes
> >> > > without going into full suspend.
> >> >
> >> > /me likes.
> >> >
> >> > > Then you just need to convince us that this mechanism can be used without any
> >> > > race problems. If it can, then it would certainly be a simple and
> >> > > unobtrusive approach.
> >> >
> >> > Lets find out.
> >>
> >> Simple question: how is that better than the Alan Stern's proposed approach?
> >>
> > I just saw Alan Stern's proposal, and have gotten some input form some
> > others. I can't say my patch represents a better Idea than what Alan
> > proposed. However; what Alan (and Thomas) are talking about is
> > effectively the same as the kenrel mode wakelock/suspend blocker thing,
> > and although it reuses existing infrastructure, it doesn't solve the
> > problem of needing overlapping blocking sections of code from ISR to
> > user mode.
> >
>
> I don't think your solution solves this either.
Why? my proposal effectively removes the overlapping kernel blocking
sections uppon wake up by forcing the user mode to ack the wake event
and re-issue the suspend request explicitly. That pretty much solves
that problem.
We can talk about whether or not it can be used effectively with Android
user mode PM or not, which I still think it can, but I need to try the
mods to power.c.
--mgross
> --
> Arve Hjønnevåg
next prev parent reply other threads:[~2010-06-01 14:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 20:04 [RFC] lp_events: an lternitive to suspend blocker user mode and kernel API mark gross
2010-05-30 23:57 ` Neil Brown
2010-05-31 6:43 ` Florian Mickler
2010-05-31 8:05 ` Florian Mickler
2010-05-31 22:43 ` mark gross
2010-05-31 22:26 ` mark gross
2010-05-31 22:10 ` mark gross
2010-05-31 22:45 ` Rafael J. Wysocki
2010-06-01 5:09 ` [linux-pm] " mark gross
2010-06-01 5:24 ` Arve Hjønnevåg
2010-06-01 14:01 ` mark gross [this message]
2010-06-02 3:10 ` Arve Hjønnevåg
2010-06-02 3:24 ` Gross, Mark
2010-06-02 4:26 ` Arve Hjønnevåg
2010-05-31 9:55 ` Arve Hjønnevåg
2010-05-31 23:03 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601140120.GB1281@gvim.org \
--to=640e9920@gmail.com \
--cc=Arve@smtp1.linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arve@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mark.gross@intel.com \
--cc=markgross@thegnar.org \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=swetland@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox