From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@elte.hu>,
perfmon2-devel@lists.sf.net, eranian@gmail.com,
"David S. Miller" <davem@davemloft.net>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
"Paul Mackerras" <paulus@samba.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Tom Zanussi" <tzanussi@gmail.com>
Subject: Re: [BUG] perf: buildid not managed properly when cmd path is relative
Date: Tue, 1 Jun 2010 17:23:40 -0300 [thread overview]
Message-ID: <20100601202340.GE4093@ghostprotocols.net> (raw)
In-Reply-To: <AANLkTinpaxSIEmqetcXDZIRdLUT7IuVPGInwTqN9F5cQ@mail.gmail.com>
Em Tue, Jun 01, 2010 at 10:05:24PM +0200, Stephane Eranian escreveu:
> Hi,
>
> You patch does seem to fix the problem.
thanks for confirming.
> However, I think there may be another issue, maybe
> caused by the patch.
>
> If you monitor a program WITHOUT buildids, and you run
>
> $ perf record tmp/foo
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.077 MB perf.data (~3370 samples) ]
>
> $ ./perf buildid-list
> 86200ab2bca285344a55156a079debbbe172bcc5 [kernel.kallsyms]
>
> foo does not appear, yet we know it got samples.
>
> $ ./perf buildid-list --with-hits
> 86200ab2bca285344a55156a079debbbe172bcc5 [kernel.kallsyms]
> 0000000000000000000000000000000000000000 /home/eranian/tmp/foo
>
> With the --with-hits option, I get more output than without.Supposedly
> no option means 'prints all entries', including those with hits or
> without buildids.
Right, I noticed that too, but concentrated on fixing the problem that
was clearly a bug, will add this to my TODO list as I agree this is
inconsistent and/or incomplete behaviour.
Will add a Tested-by: you and push it to Ingo via perf/urgent.
Thanks for testing,
- Arnaldo
prev parent reply other threads:[~2010-06-01 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 13:46 [BUG] perf: buildid not managed properly when cmd path is relative Stephane Eranian
2010-05-29 22:57 ` Arnaldo Carvalho de Melo
2010-06-01 18:38 ` Arnaldo Carvalho de Melo
2010-06-01 20:05 ` Stephane Eranian
2010-06-01 20:23 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601202340.GE4093@ghostprotocols.net \
--to=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox