From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jens Axboe <jaxboe@fusionio.com>, Vivek Goyal <vgoyal@redhat.com>,
Tejun Heo <tj@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Douglas Gilbert <dgilbert@interlog.com>,
Ingo Molnar <mingo@redhat.com>, John Kacur <jkacur@redhat.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: replace BKL with global mutex
Date: Tue, 1 Jun 2010 17:37:55 -0400 [thread overview]
Message-ID: <20100601213755.GA1004@infradead.org> (raw)
In-Reply-To: <1275428028-10901-1-git-send-email-arnd@arndb.de>
NAK. You're really only creation a mini-BKL here without
sorting out the locking. Please go through the individual
callers and sort them out. Start by pushing the remaining
ioctls to the unlocked version and moving the BKL into the
->open and ->release methods.
next prev parent reply other threads:[~2010-06-01 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 21:33 [PATCH] block: replace BKL with global mutex Arnd Bergmann
2010-06-01 21:37 ` Christoph Hellwig [this message]
2010-06-01 22:43 ` [PATCH] block: push down BKL into .locked_ioctl Arnd Bergmann
2010-06-02 10:16 ` Christoph Hellwig
2010-06-02 14:46 ` [PATCH] block: push down BKL into .open and .release Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601213755.GA1004@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=dgilbert@interlog.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=fweisbec@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).