From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: sonic zhang <sonic.adi@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
uclinux-dist-devel <uclinux-dist-devel@blackfin.uclinux.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Uclinux-dist-devel] [PATCH v2] regulator: new drivers for AD5398 and AD5821
Date: Wed, 2 Jun 2010 10:47:33 +0100 [thread overview]
Message-ID: <20100602094733.GA13983@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTinaPmKUx04I1mjNhla4s3S6vmWp8x6eoDTZGRVz@mail.gmail.com>
On Wed, Jun 02, 2010 at 05:02:58AM -0400, Mike Frysinger wrote:
> > + dev_dbg(&client->dev, "%s regulator driver loaded\n", id->name);
> does the regulator core take care of displaying a notice ? if not,
> i'd make this dev_info(). also, this should be "registered", not
> "loaded".
A message will be displayed if the device actually has any constraints
(and is therefore in use) so if it makes any difference to the system
there will be some chat.
> > +MODULE_DESCRIPTION("AD5398 and AD5821 current regulator driver");
> > +MODULE_AUTHOR("Sonic Zhang");
> > +MODULE_LICENSE("GPL");
> should there be a MODULE_ALIAS() ?
Possibly, though it's unlikely that actual systems will ever build a
regulator they're using as a module.
next prev parent reply other threads:[~2010-06-02 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 8:51 [PATCH v2] regulator: new drivers for AD5398 and AD5821 sonic zhang
2010-06-02 9:02 ` [Uclinux-dist-devel] " Mike Frysinger
2010-06-02 9:29 ` Sonic Zhang
2010-06-02 9:36 ` Mike Frysinger
2010-06-02 10:10 ` Sonic Zhang
2010-06-02 10:18 ` Mike Frysinger
2010-06-02 9:47 ` Mark Brown [this message]
2010-06-02 10:33 ` Mark Brown
2010-06-03 2:57 ` Sonic Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602094733.GA13983@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sonic.adi@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox