linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jens Axboe <axboe@kernel.dk>
Cc: Peter Zijlstra <peterz@infradead.org>,
	piotr@hosowicz.com, linux-kernel@vger.kernel.org,
	Divyesh Shah <dpshah@google.com>
Subject: blkiocg_update_io_add_stats(): INFO: trying to register non-static key
Date: Wed, 2 Jun 2010 13:16:53 +0200	[thread overview]
Message-ID: <20100602111653.GA25662@elte.hu> (raw)
In-Reply-To: <20100601065500.GA7876@elte.hu>


btw., there's another warning triggered by the new blk-cgroups stats code:

sda:INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
Pid: 81, comm: async/2 Not tainted 2.6.35-rc1-tip-01073-gd2f7698-dirty #6765
Call Trace:
 [<ffffffff81065d6d>] register_lock_class+0x15f/0x365
 [<ffffffff8105c426>] ? sched_clock_local+0x1d/0x83
 [<ffffffff8105c557>] ? sched_clock_cpu+0xcb/0xd9
 [<ffffffff81067184>] __lock_acquire+0x97/0x481
 [<ffffffff810088d4>] ? native_sched_clock+0x37/0x6d
 [<ffffffff81321b74>] ? blkiocg_update_io_add_stats+0x32/0x12e
 [<ffffffff81067644>] lock_acquire+0xd6/0xfd
 [<ffffffff81321b74>] ? blkiocg_update_io_add_stats+0x32/0x12e
 [<ffffffff81850859>] _raw_spin_lock_irqsave+0x47/0x82
 [<ffffffff81321b74>] ? blkiocg_update_io_add_stats+0x32/0x12e
 [<ffffffff81321b74>] blkiocg_update_io_add_stats+0x32/0x12e
 [<ffffffff81325048>] cfq_insert_request+0xdd/0x47c
 [<ffffffff813135b9>] elv_insert+0x12a/0x1f4
 [<ffffffff8131371c>] __elv_add_request+0x99/0xa1
 [<ffffffff8131817a>] __make_request+0x3e2/0x45f
 [<ffffffff8131736e>] generic_make_request+0x2a0/0x316
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff8131749c>] submit_bio+0xb8/0xd6
 [<ffffffff81117e1b>] submit_bh+0xf5/0x117
 [<ffffffff8111b36e>] block_read_full_page+0x1f2/0x214
 [<ffffffff8111ce86>] ? blkdev_get_block+0x0/0x66
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff810c6ddd>] ? __lru_cache_add+0x79/0x97
 [<ffffffff8111de4d>] blkdev_readpage+0x18/0x1a
 [<ffffffff810becb0>] do_read_cache_page+0x95/0x128
 [<ffffffff8111de35>] ? blkdev_readpage+0x0/0x1a
 [<ffffffff810bed87>] read_cache_page_async+0x1c/0x1e
 [<ffffffff810bed97>] read_cache_page+0xe/0x18
 [<ffffffff8114698f>] read_dev_sector+0x33/0xbe
 [<ffffffff8114797d>] adfspart_check_EESOX+0x59/0x1e7
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff8185405e>] ? sub_preempt_count+0xf/0xb7
 [<ffffffff8103dede>] ? vprintk+0x395/0x3f0
 [<ffffffff811472f0>] ? kzalloc.clone.1+0x13/0x15
 [<ffffffff8184dfe5>] ? printk+0x69/0x6b
 [<ffffffff8114771d>] rescan_partitions+0x186/0x38d
 [<ffffffff81513cfb>] ? sd_open+0xf1/0x1bd
 [<ffffffff8111e512>] __blkdev_get+0x291/0x372
 [<ffffffff8132a4ba>] ? kobject_put+0x48/0x4c
 [<ffffffff8111e603>] blkdev_get+0x10/0x12
 [<ffffffff81146bcd>] register_disk+0xb9/0x11d
 [<ffffffff8131f3c4>] add_disk+0xb0/0x10c
 [<ffffffff81515d4c>] sd_probe_async+0x12a/0x200
 [<ffffffff8105f4a4>] ? ktime_get+0x65/0xbe
 [<ffffffff8105d742>] async_thread+0x10e/0x21c
 [<ffffffff81039390>] ? default_wake_function+0x0/0x14
 [<ffffffff8105d634>] ? async_thread+0x0/0x21c
 [<ffffffff81056c01>] kthread+0x9b/0xa3
 [<ffffffff810030f4>] kernel_thread_helper+0x4/0x10
 [<ffffffff81056b66>] ? kthread+0x0/0xa3
 [<ffffffff810030f0>] ? kernel_thread_helper+0x0/0x10
 sda1 sda2 sda3 < sda5 sda6 sda7 sda8 sda9 sda10 >
device: 'sda1': device_add
PM: Adding info for No Bus:sda1

seems to be a lock taken by:

 [<ffffffff81321b74>] blkiocg_update_io_add_stats+0x32/0x12e

	Ingo

  parent reply	other threads:[~2010-06-02 11:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24  3:03 BUG: using smp_processor_id() in preemptible [00000000] code: icedove-bin/5449 Piotr Hosowicz
2010-05-24 17:22 ` Piotr Hosowicz
2010-05-25  8:50 ` Peter Zijlstra
2010-05-25  9:42   ` Piotr Hosowicz
2010-05-25  9:45     ` Peter Zijlstra
2010-05-25  9:43   ` Ingo Molnar
2010-05-25  9:47     ` Peter Zijlstra
2010-05-25  9:51       ` Peter Zijlstra
2010-05-25  9:57     ` Piotr Hosowicz
2010-05-25 10:00       ` Peter Zijlstra
2010-05-25 10:05         ` Piotr Hosowicz
2010-05-25 10:29           ` Piotr Hosowicz
2010-05-25 14:13             ` Piotr Hosowicz
2010-05-25 14:34               ` Piotr Hosowicz
2010-05-25 14:36                 ` Peter Zijlstra
2010-05-25 14:48                   ` Piotr Hosowicz
2010-05-25 16:15                     ` Peter Zijlstra
2010-05-25 16:47                       ` Piotr Hosowicz
2010-05-26  2:06                         ` Piotr Hosowicz
2010-05-26  2:51                           ` Piotr Hosowicz
2010-05-25 18:07   ` Divyesh Shah
2010-05-25 18:15     ` Piotr Hosowicz
2010-05-25 21:35     ` Peter Zijlstra
2010-05-26 23:02   ` Andrew Morton
2010-05-27  6:46     ` Peter Zijlstra
2010-05-27  6:51       ` Andrew Morton
     [not found]         ` <1274945751.27810.3765.camel@twins>
     [not found]           ` <20100527113340.d4afb8fc.akpm@linux-foundation.org>
2010-05-28 13:13             ` [PATCH] sched_clock: Provide local_clock() and improve documentation Peter Zijlstra
2010-05-28 13:42               ` Johannes Stezenbach
2010-05-28 15:08                 ` Peter Zijlstra
2010-05-28 14:15               ` Piotr Hosowicz
2010-05-28 14:22                 ` Piotr Hosowicz
2010-05-28 18:11               ` Chad Talbott
2010-05-28 18:22                 ` Peter Zijlstra
2010-06-09 10:13               ` [tip:sched/core] sched_clock: Add local_clock() API " tip-bot for Peter Zijlstra
2010-06-01  6:41   ` BUG: using smp_processor_id() in preemptible [00000000] code: icedove-bin/5449 Ingo Molnar
2010-06-01  6:47     ` Jens Axboe
2010-06-01  6:55       ` Ingo Molnar
2010-06-01  7:53         ` Jens Axboe
2010-06-12  1:54           ` Divyesh Shah
2010-06-12  9:42             ` Peter Zijlstra
2010-06-02 11:16         ` Ingo Molnar [this message]
2010-06-02 13:04           ` blkiocg_update_io_add_stats(): INFO: trying to register non-static key Jens Axboe
2010-06-11  1:33             ` Divyesh Shah
2010-06-11  7:15             ` Peter Zijlstra
2010-06-11  8:34               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100602111653.GA25662@elte.hu \
    --to=mingo@elte.hu \
    --cc=axboe@kernel.dk \
    --cc=dpshah@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=piotr@hosowicz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).