From: Christoph Hellwig <hch@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
John Kacur <jkacur@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Jan Blunck <jblunck@suse.de>
Subject: Re: [RFC 4/5] BKL: use no BKL in llseek
Date: Thu, 3 Jun 2010 03:08:27 -0400 [thread overview]
Message-ID: <20100603070827.GB12123@infradead.org> (raw)
In-Reply-To: <20100603003826.GD5164@nowhere>
On Thu, Jun 03, 2010 at 02:38:27AM +0200, Frederic Weisbecker wrote:
> This should be simply dropped and we can make use of generic_file_llseek
> instead, as the fallback llseek.
generic_file_llseek contains the sb->s_maxbytes check, so it needs at
least a careful audit first. But as mentioned about a dozend times
before it's an just as bad default. The correct default to go ahead
it to not allow seeking and pread/pwrite unless a ->lseek method is set,
and I've already explained a step by step guide how to get there in
easily bisectable steps. And the addition of nonseekable_open/no_llseek
by you BKL guys already got us much closer to this, so please follow up
on that work and do it properly.
next prev parent reply other threads:[~2010-06-03 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 0:13 [RFC 0/5] BKL removal leftovers Arnd Bergmann
2010-06-03 0:13 ` [RFC 1/5] BKL: autoconvert trivial users to private mutex Arnd Bergmann
2010-06-03 0:35 ` Frederic Weisbecker
2010-06-03 16:50 ` Greg KH
2010-06-03 0:13 ` [RFC 2/5] BKL: remove the BKL from kernel init code Arnd Bergmann
2010-06-03 1:07 ` Steven Rostedt
2010-06-03 0:13 ` [RFC 3/5] BKL: do not take BKL in do_coredump Arnd Bergmann
2010-06-03 0:13 ` [RFC 4/5] BKL: use no BKL in llseek Arnd Bergmann
2010-06-03 0:38 ` Frederic Weisbecker
2010-06-03 7:08 ` Christoph Hellwig [this message]
2010-06-03 7:06 ` Christoph Hellwig
2010-06-03 23:47 ` Arnd Bergmann
2010-06-03 7:41 ` Geert Uytterhoeven
2010-06-03 0:13 ` [RFC 5/5] BKL: introduce CONFIG_BKL Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603070827.GB12123@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=jblunck@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).