From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756995Ab0FCQrg (ORCPT ); Thu, 3 Jun 2010 12:47:36 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42097 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab0FCQrf (ORCPT ); Thu, 3 Jun 2010 12:47:35 -0400 Date: Thu, 3 Jun 2010 09:45:46 -0700 From: Andrew Morton To: Adam Lackorzynski Cc: Jacob Pan , "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, i8259: Only register sysdev for real PIC Message-Id: <20100603094546.af7db742.akpm@linux-foundation.org> In-Reply-To: <20100603090141.GA15516@os.inf.tu-dresden.de> References: <20100602113150.GB21413@os.inf.tu-dresden.de> <20100602181814.63b173be.akpm@linux-foundation.org> <20100603090141.GA15516@os.inf.tu-dresden.de> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Jun 2010 11:01:41 +0200 Adam Lackorzynski wrote: > > On Wed Jun 02, 2010 at 18:18:14 -0700, Andrew Morton wrote: > > On Wed, 2 Jun 2010 13:31:50 +0200 Adam Lackorzynski wrote: > > > > > Do not register the sysdev function when the null_legacy_pic is used so > > > that the i8259 resume, suspend and shutdown functions are not called. > > > > What are the effects of this change? Does it fix an oops or a hang, or > > nothing at all, or...? > > My platform makes use of the null_legacy_pic choice and oopses when > doing a shutdown as the shutdown code goes through all the registered > sysdevs and calls their shutdown method which in my case poke on a > non-existing i8259. Imho the i8259 specific sysdev should only be > registered if the i8259 is actually there. OK, thanks. Important info, that. I'd say that makes it something we should fix in 2.6.34.x and perhaps earlier.