Re: [PATCH] use unfair spinlock when running on hypervisor.

Gleb Natapov
2010-06-01T16:24:49Z

On Tue, Jun 01, 2010 at 05:53:09PM +0200, Andi Kleen wrote:
> Gleb Natapov <gleb@redhat.com> writes:
> >
> > The patch below allows to patch ticket spinlock code to behave similar to
> > old unfair spinlock when hypervisor is detected. After patching unlocked
>
> The question is what happens when you have a system with unfair
> memory and you run the hypervisor on that. There it could be much worse.
>
How much worse performance hit could be?

> Your new code would starve again, right?
>
Yes, of course it may starve with unfair spinlock. Since vcpus are not
always running there is much smaller chance then vcpu on remote memory
node will starve forever. Old kernels with unfair spinlocks are running
fine in VMs on NUMA machines with various loads.

> There's a reason the ticket spinlocks were added in the first place.
>
I understand that reason and do not propose to get back to old spinlock
on physical HW! But with virtualization performance hit is unbearable.

--
Gleb.