Re: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes

[Greg KH <gregkh@suse.de>]

On Thu, Jun 03, 2010 at 01:57:27PM +0200, Daniel Mack wrote:
> On Thu, Jun 03, 2010 at 01:55:02PM +0200, Daniel Mack wrote:
> > Call set_mctrl() and clear_mctrl() according to the flow control mode
> > selected. This makes serial communication for FT232 connected devices
> > work when CRTSCTS is not set.
> > 
> > This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> > opened non blocking we still need to raise the carrier"). This patch
> > calls the low-level driver's dtr_rts() function which consequently sets
> > TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without CRTSCTS in
> > cflags, however, does not reset these bits, and so data is not actually
> > sent out on the serial wire.
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Johan Hovold <jhovold@gmail.com>
> > Cc: Alan Cox <alan@linux.intel.com>
> > Cc: linux-usb@vger.kernel.org
> 
> Oops. I forgot to Cc: stable@kernel.org.
> This is in fact broken since 2.6.31-something.

Thanks for letting me know, I'll add that marking to the patch when I
queue it up.

thanks,

greg k-h