From: Stephen Hemminger <shemminger@vyatta.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0
Date: Thu, 3 Jun 2010 14:49:13 -0700 [thread overview]
Message-ID: <20100603144913.24828629@nehalam> (raw)
In-Reply-To: <alpine.LFD.2.00.1006031355140.8175@i5.linux-foundation.org>
It seems it isn't related to initial jiffies.
Initializing the values (though a good idea), doesn't solve the
problem. Still failed. So dazed and confused, went back and reran
kernel with jiffies=0 showed same problem, just took multiple boots
to reproduce.
> for (dr = 0; dr < N_DRIVE; dr++) {
> @@ -4267,6 +4269,9 @@ static int __init floppy_init(void)
> set_bit(FD_DISK_CHANGED_BIT, &UDRS->flags);
> set_bit(FD_VERIFY_BIT, &UDRS->flags);
> UDRS->fd_device = -1;
> + UDRS->last_checked = jiffies;
> + UDRS->select_date = jiffies;
> + UDRS->spinup_date = jiffies;
> floppy_track_buffer = NULL;
> max_buffer_sectors = 0;
> }
So still a race that shows up with KVM (fast floppy?) and manifests
as floppy_ready or reset_interrupt OOPS.
next prev parent reply other threads:[~2010-06-03 21:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 17:15 floppy driver assumes INITIAL_JIFFIES == 0 Stephen Hemminger
2010-06-03 17:28 ` Linus Torvalds
2010-06-03 19:03 ` Stephen Hemminger
2010-06-03 19:56 ` Linus Torvalds
2010-06-03 20:59 ` Linus Torvalds
2010-06-03 21:49 ` Stephen Hemminger [this message]
2010-06-03 21:58 ` Linus Torvalds
2010-06-03 22:33 ` Linus Torvalds
2010-06-03 22:54 ` Stephen Hemminger
2010-06-03 23:09 ` Linus Torvalds
2010-06-03 23:15 ` Stephen Hemminger
2010-06-03 23:21 ` Linus Torvalds
2010-06-09 5:32 ` Stephen Hemminger
2010-06-03 22:32 ` Andreas Mohr
2010-06-03 22:40 ` Linus Torvalds
2010-06-04 15:12 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603144913.24828629@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox