Re: [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly 05000230

Greg KH
2010-06-03T17:53:13Z

On Thu, Jun 03, 2010 at 10:41:31AM -0700, Greg KH wrote:
> On Mon, May 31, 2010 at 07:29:31AM -0400, Mike Frysinger wrote:
> > From: Graf Yang <graf.yang@analog.com>
> >
> > Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
> > the peripheral is operating in UART mode. So drop the anomaly handling
> > when the UART is in IRDA mode.
> >
> > Signed-off-by: Graf Yang <graf.yang@analog.com>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > drivers/serial/bfin_5xx.c | 7 ++++++-
> > 1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> > index 96f7e74..a78652b 100644
> > --- a/drivers/serial/bfin_5xx.c
> > +++ b/drivers/serial/bfin_5xx.c
> > @@ -869,7 +869,12 @@ bfin_serial_set_termios(struct uart_port *port, struct ktermios *termios,
> > }
> >
> > baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
> > - quot = uart_get_divisor(port, baud) - ANOMALY_05000230;
> > + quot = uart_get_divisor(port, baud);
> > +
> > + /* If discipline is not IRDA, apply ANOMALY_05000230 */
> > + if (termios->c_line != N_IRDA)
> > + quot -= ANOMALY_05000230;
> > +
>
> This can't be applied to the current tree, did you make it backwards?

Crap, that's because I already had it in my tree, doh...