Re: [RFC][PATCH 26/26] alsa: ASoC: JZ4740: Add qi_lb60 board driver

Mark Brown
2010-06-03T17:57:18Z

On Wed, Jun 02, 2010 at 09:15:32PM +0200, Lars-Peter Clausen wrote:

> + ret = gpio_request(QI_LB60_SND_GPIO, "SND");
> + if (ret) {
> + pr_err("qi_lb60 snd: Failed to request SND GPIO(%d): %d\n",
> + QI_LB60_SND_GPIO, ret);
> + goto err_device_put;
> + }
> +
> + ret = gpio_request(QI_LB60_AMP_GPIO, "AMP");
> + if (ret) {
> + pr_err("qi_lb60 snd: Failed to request AMP GPIO(%d): %d\n",
> + QI_LB60_AMP_GPIO, ret);
> + goto err_gpio_free_snd;
> + }
> +
> + gpio_direction_output(JZ_GPIO_PORTB(29), 0);
> + gpio_direction_output(JZ_GPIO_PORTD(4), 0);

You're referring to the GPIOs by multiple different names - it'd be more
robust to pick one way of naming them and use it consistently (probably
the #define).