From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Thomas Renninger <trenn@suse.de>
Subject: Re: mmotm 2010-06-03-16-36 uploaded
Date: Thu, 3 Jun 2010 18:54:01 -0700 [thread overview]
Message-ID: <20100603185401.1851c94e.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTilX_Fbc_pR1jtgQJsvu7RbMfgyhJYCxqV725T18@mail.gmail.com>
On Fri, 4 Jun 2010 09:41:58 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> On Fri, Jun 4, 2010 at 7:36 AM, <akpm@linux-foundation.org> wrote:
> > The mm-of-the-moment snapshot 2010-06-03-16-36 has been uploaded to
> >
> > __ http://userweb.kernel.org/~akpm/mmotm/
> >
>
> Hi, intel_idle build fails:
>
> drivers/idle/intel_idle.c: In function ___intel_idle___:
> drivers/idle/intel_idle.c:234: error: too few arguments to function ___trace_power
> _start___
> make[2]: *** [drivers/idle/intel_idle.o] Error 1
> make[1]: *** [drivers/idle] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
Caused by
x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent.patch
which changed trace_power_start().
drivers/idle/intel_idle.c wasn't there when Thomas wrote that patch.
this, I guess:
--- a/drivers/idle/intel_idle.c~x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent-fix
+++ a/drivers/idle/intel_idle.c
@@ -231,7 +231,7 @@ static int intel_idle(struct cpuidle_dev
stop_critical_timings();
#ifndef MODULE
- trace_power_start(POWER_CSTATE, (eax >> 4) + 1);
+ trace_power_start(POWER_CSTATE, (eax >> 4) + 1, cpu);
#endif
if (!need_resched()) {
_
it's a bit odd that all trace_power_start() callers just pass in
smp_processor_id(). Why not do it within trace_power_start() itself?
next prev parent reply other threads:[~2010-06-04 1:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 23:36 mmotm 2010-06-03-16-36 uploaded akpm
2010-06-04 1:14 ` FUJITA Tomonori
2010-06-04 1:34 ` Andrew Morton
2010-06-04 2:16 ` FUJITA Tomonori
2010-06-04 9:32 ` Michael Büsch
2010-06-04 1:41 ` Dave Young
2010-06-04 1:54 ` Andrew Morton [this message]
2010-06-04 2:02 ` Dave Young
2010-06-04 2:10 ` Andrew Morton
2010-06-04 2:13 ` Dave Young
2010-06-04 1:56 ` Andrew Morton
2010-06-04 2:23 ` Valdis.Kletnieks
2010-06-04 16:41 ` [PATCH -mmotm] cciss: fix build for CONFIG_PROC_FS=n Randy Dunlap
2010-06-04 18:07 ` Miller, Mike (OS Dev)
2010-06-05 12:15 ` mmotm 2010-06-03-16-36 uploaded Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603185401.1851c94e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mm-commits@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox