* [PATCH] perf: make annotate demangle symbols
@ 2010-06-03 13:50 Stephane Eranian
2010-06-04 2:15 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Stephane Eranian @ 2010-06-03 13:50 UTC (permalink / raw)
To: linux-kernel
Cc: peterz, mingo, paulus, davem, fweisbec, acme, perfmon2-devel,
eranian, eranian, tzanussi
Perf report is demangling symbols but not annotate.
The former uses internal demangling via libbdf or
libiberty. The latter executes objdump which by default
does not demangle symbols.
This patch adds the -C option to the objdump cmdline
to enable symbol demangling.
Signed-off-by: Stephane Eranian <eranian@google.com>
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 07f89b6..9e6baad 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1037,7 +1037,7 @@ fallback:
dso, dso->long_name, sym, sym->name);
snprintf(command, sizeof(command),
- "objdump --start-address=0x%016Lx --stop-address=0x%016Lx -dS %s|grep -v %s|expand",
+ "objdump --start-address=0x%016Lx --stop-address=0x%016Lx -dS -C %s|grep -v %s|expand",
map__rip_2objdump(map, sym->start),
map__rip_2objdump(map, sym->end),
filename, filename);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: make annotate demangle symbols
2010-06-03 13:50 [PATCH] perf: make annotate demangle symbols Stephane Eranian
@ 2010-06-04 2:15 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-06-04 2:15 UTC (permalink / raw)
To: Stephane Eranian
Cc: linux-kernel, peterz, mingo, paulus, davem, fweisbec,
perfmon2-devel, eranian, tzanussi
Em Thu, Jun 03, 2010 at 03:50:01PM +0200, Stephane Eranian escreveu:
> Perf report is demangling symbols but not annotate.
> The former uses internal demangling via libbdf or
> libiberty. The latter executes objdump which by default
> does not demangle symbols.
>
> This patch adds the -C option to the objdump cmdline
> to enable symbol demangling.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Thanks, Applied.
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-04 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 13:50 [PATCH] perf: make annotate demangle symbols Stephane Eranian
2010-06-04 2:15 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox