From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <kees.cook@canonical.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Dave Young <hidave.darkstar@gmail.com>,
Eric Paris <eparis@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
James Morris <jmorris@namei.org>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tim Gardner <tim.gardner@canonical.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH v6] fs: allow protected cross-uid sticky symlinks
Date: Fri, 4 Jun 2010 05:39:06 +0100 [thread overview]
Message-ID: <20100604043906.GB31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100603184054.GA4714@outflux.net>
On Thu, Jun 03, 2010 at 11:40:54AM -0700, Kees Cook wrote:
> At this point, I believe I've addressed the specific concerns that Al Viro,
> Eric Paris, and a few others pointed out. What else needs fixing?
The hell you have. Let me spell it out for you:
1) You _still_ have not posted the analysis of changes it causes, let alone
explained why they are the right thing to do.
2) You are still doing that for each symlink, no matter where in the path
it might be. Do (1) and you'll see why it is a BS.
3) You have not bothered to explain why e.g. stat(2) should fail on such
symlinks. Nevermind figuring out which syscalls need that and which do
not. Again, (1) would be the starting point required for the rest. And
it is needed to decide how to deal with these checks. Really.
next prev parent reply other threads:[~2010-06-04 4:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 8:01 [PATCH v6] fs: allow protected cross-uid sticky symlinks Kees Cook
2010-06-03 9:41 ` Alan Cox
2010-06-03 18:40 ` Kees Cook
2010-06-04 4:39 ` Al Viro [this message]
2010-06-04 6:23 ` Kees Cook
2010-06-03 20:02 ` Eric W. Biederman
2010-06-03 21:00 ` Kees Cook
2010-06-07 16:18 ` Valdis.Kletnieks
2010-06-07 16:42 ` Kees Cook
2010-06-07 18:36 ` Eric W. Biederman
2010-06-07 21:06 ` Kees Cook
2010-06-08 8:25 ` Alan Cox
2010-06-07 19:10 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604043906.GB31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=jkosina@suse.cz \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=schwidefsky@de.ibm.com \
--cc=serue@us.ibm.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox