From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Palix <npalix@diku.dk>
Cc: Michal Marek <mmarek@suse.cz>,
Randy Dunlap <rdunlap@xenotime.net>,
Roland Dreier <rdreier@cisco.com>, Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Julia Lawall <julia@diku.dk>,
Gilles Muller <Gilles.Muller@lip6.fr>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
cocci@diku.dk, Wolfram Sang <w.sang@pengutronix.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 1/4] Add targets to use the Coccinelle checker
Date: Fri, 4 Jun 2010 12:38:20 +0200 [thread overview]
Message-ID: <20100604103820.GA10104@merkur.ravnborg.org> (raw)
In-Reply-To: <201006041156.20714.npalix@diku.dk>
> >
> > A nice simplification of the top-level Mkefile.
> > and an opportunity to document some of the
> > magic shell commands used by the various tools.
...
>
> I am not sure to understand your suggestion.
>
> Should I make this change and integrate it into my patch series
> or it is something to do later ?
If we agree on this as the base infrastructure I would
like you to introduce it as part of adding Coccinelle support.
That should not touch the existing targets - but only
add Coccinelle support. But in a way so we have the
infrastructure in place so we can later move the other targets later.
>
> In doing so, I will have to select the 'mode' in a different way.
> I was thinking of renaming my targets in one of the following forms
> or using an environment variable:
>
> make cocci-report-check
> make report-coccicheck
> make coccicheck MODE=report
I like the latter.
If you do "make coccicheck" then you can show a list of
possible mode's. And if MODE is set you use this mode.
Sam
next prev parent reply other threads:[~2010-06-04 10:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 16:24 [PATCH 0/4] Add a Coccinelle front-end script Nicolas Palix
2010-05-10 16:24 ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-05-12 6:42 ` Américo Wang
2010-05-28 7:04 ` Joerg Roedel
2010-06-03 9:50 ` Michal Marek
2010-06-03 10:23 ` Sam Ravnborg
2010-06-04 9:56 ` Nicolas Palix
2010-06-04 10:38 ` Sam Ravnborg [this message]
2010-05-10 16:24 ` [PATCH 2/4] Add scripts/coccinelle/drop_kmalloc_cast.cocci Nicolas Palix
2010-05-10 16:24 ` [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Nicolas Palix
2010-06-03 9:51 ` Michal Marek
2010-06-03 10:11 ` Nicolas Palix
2010-05-10 16:24 ` [PATCH 4/4] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-05-10 16:52 ` Pekka Enberg
2010-05-27 11:48 ` Nicolas Palix
2010-05-11 2:14 ` [PATCH 0/4] Add a Coccinelle front-end script Andy Isaacson
2010-05-17 9:31 ` Wolfram Sang
2010-05-28 7:09 ` Joerg Roedel
2010-05-28 7:25 ` Wolfram Sang
2010-05-28 7:31 ` Julia Lawall
2010-05-28 7:39 ` walter harms
2010-05-28 9:15 ` Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2010-04-26 21:11 Nicolas Palix
2010-04-26 21:11 ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-04-26 21:37 ` Joe Perches
2010-04-26 22:20 ` Nicolas Palix
2010-04-26 22:23 ` Randy Dunlap
2010-04-29 17:01 ` Roland Dreier
2010-04-30 21:07 ` Randy Dunlap
2010-04-27 12:40 ` Michal Marek
2010-04-27 13:01 ` Michal Marek
2010-04-27 12:53 ` Wolfram Sang
2010-04-27 20:24 ` Sam Ravnborg
2010-04-27 20:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604103820.GA10104@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Gilles.Muller@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=cocci@diku.dk \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=npalix@diku.dk \
--cc=rdreier@cisco.com \
--cc=rdunlap@xenotime.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).