public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (rr tree related)
Date: Fri, 4 Jun 2010 15:06:59 +0930	[thread overview]
Message-ID: <201006041506.59887.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100604144933.86b3f2a8.sfr@canb.auug.org.au>

On Fri, 4 Jun 2010 02:19:33 pm Stephen Rothwell wrote:
> Hi Rusty,
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> kernel/module.c: In function 'post_relocation':
> kernel/module.c:2526: error: 'struct module' has no member named 'percpu_size'
> 
> Caused by commit fc77407bc287ed250f9355fda435df5f78b45885 ("module:
> simplify per-cpu handling a little").
> 
> This build has CONFIG_SMP not set

Actually, I think that cleanup is broken.  If someone were to have relocations
inside their per-cpu area, the relocation code would smash something random.

So, a doubly bad idea.  I've dropped the commit.

Thanks!
Rusty.

  reply	other threads:[~2010-06-04  5:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  4:49 linux-next: build failure after merge of the final tree (rr tree related) Stephen Rothwell
2010-06-04  5:36 ` Rusty Russell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-05  6:44 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006041506.59887.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox