Re: [PATCH v2 1/1] perf tools: Make target to generate self contained source tarball

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Tue, Jun 01, 2010 at 12:28:58PM +0200, Michal Marek escreveu:
> On 1.6.2010 01:06, Arnaldo Carvalho de Melo wrote:
> > Well, what about the other aspects of the patch, is this the only issue
> > you have found with it?
> 
> The patch is OK.
> 
> Acked-by: Michal Marek <mmarek@suse.cz>

Argh, there was one last detail, so that we don't require that the
kernel be configured first, and as we don't use KERNELRELEASE at all in
the -src-pkg targets, would that be OK with you too?

[acme@emilia linux-2.6-tip]$ git diff Makefile 
diff --git a/Makefile b/Makefile
index 0ab0c6f..6e186a1 100644
--- a/Makefile
+++ b/Makefile
@@ -1215,6 +1215,8 @@ distclean: mrproper
 # rpm target kept for backward compatibility
 package-dir    := $(srctree)/scripts/package
 
+%src-pkg: FORCE
+       $(Q)$(MAKE) $(build)=$(package-dir) $@
 %pkg: include/config/kernel.release FORCE
        $(Q)$(MAKE) $(build)=$(package-dir) $@
 rpm: include/config/kernel.release FORCE
[acme@emilia linux-2.6-tip]$

On a make mrproper'ed kernel we get:

a linux-2.6-tip]$ LANG= make perf-tarbz2-src-pkg
/bin/sh: include/config/kernel.release: No such file or directory
make: *** [include/config/kernel.release] Error 1
[acme@emilia linux-2.6-tip]$

:-\

If you're ok with it, I'll add it as a follow on patch that I'll send
via Ingo.

- Arnaldo