From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Evan Teran <eteran@alum.rit.edu>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] ptrace: x86: stepping in a signal handler leaks X86_EFLAGS_TF
Date: Sun, 6 Jun 2010 18:38:48 +0200 [thread overview]
Message-ID: <20100606163848.GA19800@redhat.com> (raw)
In-Reply-To: <20100602192318.GA26735@redhat.com>
On 06/02, Oleg Nesterov wrote:
>
> I am starting to think we should fix this per arch. As for x86, perhaps
> we should start with this one-liner
>
> spin_unlock_irq(¤t->sighand->siglock);
>
> tracehook_signal_handler(sig, info, ka, regs,
> - test_thread_flag(TIF_SINGLESTEP));
> + test_and_clear_thread_flag(TIF_SINGLESTEP));
>
> return 0;
> }
>
> then do other changes.
I am sending this patch. It is still not clear to me what is the
"right" fix, we need more discussion. Let's fix the bug first.
Oleg.
next prev parent reply other threads:[~2010-06-06 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 19:23 Bug 16061 - single stepping in a signal handler can cause the single step flag to get "stuck" Oleg Nesterov
2010-06-02 20:07 ` Oleg Nesterov
2010-06-06 16:38 ` Oleg Nesterov [this message]
2010-06-06 16:39 ` [PATCH 1/1] ptrace: x86: stepping in a signal handler leaks X86_EFLAGS_TF Oleg Nesterov
2010-06-16 2:31 ` Bug 16061 - single stepping in a signal handler can cause the single step flag to get "stuck" Roland McGrath
2010-06-16 19:56 ` Oleg Nesterov
2010-06-16 20:53 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100606163848.GA19800@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eteran@alum.rit.edu \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).