From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai.lu@oracle.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Yannick Roehlly <yannick.roehlly@free.fr>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] pci: clear bridge resource size if BIOS assign bad one
Date: Tue, 8 Jun 2010 14:43:50 -0700 [thread overview]
Message-ID: <20100608144350.366071fd@virtuousgeek.org> (raw)
In-Reply-To: <4C0813D7.7080900@oracle.com>
On Thu, 03 Jun 2010 13:43:03 -0700
Yinghai Lu <yinghai.lu@oracle.com> wrote:
>
> Make sure We can reject wrong size from BIOS.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=16009
> Yannick found that video does not work with 2.6.34
>
> the root cause:
> BIOS assigned wrong range to pci bridge. and before 2.6.34 kernel will
> just get range that is needed.
> for 2.6.34.
> | d65245c PCI: don't shrink bridge resources
> will try to range size is bigger than old one.
> (used by boot stage multi-try to get big BAR size for pci bridge,
> and pcie hotplug to get big range)
>
> So try to 0 for old size for pci bridge in this boot stage case.
>
> Reported-by: Yannick <yannick.roehlly@free.fr>
> Analyzed-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
Bjorn, are you ok with this version? It would probably help to have
some comments here too (I can add them), indicating that we'll try to
reassign the resource later, rather than just ignoring it as the
existing comment implies.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-06-08 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-16009-13546@https.bugzilla.kernel.org/>
[not found] ` <201005191637.13177.bjorn.helgaas@hp.com>
[not found] ` <201005202236.20444.bjorn.helgaas@hp.com>
[not found] ` <201006021536.43333.bjorn.helgaas@hp.com>
[not found] ` <4C070ECA.2020309@oracle.com>
2010-06-03 20:43 ` [PATCH -v2] pci: clear bridge resource size if BIOS assign bad one Yinghai Lu
2010-06-03 23:02 ` Yannick Roehlly
2010-06-08 21:43 ` Jesse Barnes [this message]
2010-06-08 22:48 ` Bjorn Helgaas
2010-06-08 23:36 ` Yinghai Lu
2010-06-09 23:30 ` Bjorn Helgaas
2010-06-11 8:44 ` Yannick Roehlly
2010-06-11 22:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100608144350.366071fd@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yannick.roehlly@free.fr \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox